From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
cem@kernel.org, r772577952@gmail.com, stable@vger.kernel.org,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/4] xfs: check the return value of xchk_xfile_*_descr calls
Date: Fri, 23 Jan 2026 06:33:23 +0100 [thread overview]
Message-ID: <20260123053323.GA24680@lst.de> (raw)
In-Reply-To: <20260122185701.GO5966@frogsfrogsfrogs>
On Thu, Jan 22, 2026 at 10:57:01AM -0800, Darrick J. Wong wrote:
> > > Alternately we just drop all the helpers and kasprintf crap in favor of
> > > feeding the raw string ("iunlinked next pointers") all the way through
> > > to shmem_kernel_file_setup.
> >
> > But wouldn't we get duplicate names for different inodes?
>
> Yes, but that's only used for readlink of /proc/$pid/fd/* so (AFAICT) it
> makes tracing more confusing but doesn't affect functionality.
> xfs_healthmon just passes in "xfs_healthmon" and I can run healers on
> multiple filesystems just fine.
>
> anon inodes are ... uh ... magic.
Ok, that certainly would simply things a lot, and I'd be ok with it.
My ideas didn't really work out. The last idea I had was to be able
to specify a prefix in a new method in struct xchk_meta_ops, but
this starts to feel like severe overengineering.
next prev parent reply other threads:[~2026-01-23 5:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-21 6:40 [PATCHSET] xfs: syzbot fixes for online fsck Darrick J. Wong
2026-01-21 6:40 ` [PATCH 1/4] xfs: check the return value of xchk_xfile_*_descr calls Darrick J. Wong
2026-01-21 7:03 ` Christoph Hellwig
2026-01-21 18:22 ` Darrick J. Wong
2026-01-22 5:57 ` Christoph Hellwig
2026-01-22 18:57 ` Darrick J. Wong
2026-01-23 5:33 ` Christoph Hellwig [this message]
2026-01-23 7:00 ` Darrick J. Wong
2026-01-21 6:40 ` [PATCH 2/4] xfs: only call xf{array,blob}_destroy if we have a valid pointer Darrick J. Wong
2026-02-05 19:40 ` Chris Mason
2026-02-06 4:46 ` Darrick J. Wong
2026-01-21 6:40 ` [PATCH 3/4] xfs: check return value of xchk_scrub_create_subord Darrick J. Wong
2026-01-21 7:03 ` Christoph Hellwig
2026-01-21 6:41 ` [PATCH 4/4] xfs: fix UAF in xchk_btree_check_block_owner Darrick J. Wong
2026-01-21 7:04 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260123053323.GA24680@lst.de \
--to=hch@lst.de \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=r772577952@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox