Re: [PATCH 1/4] xfs: check the return value of xchk_xfile_*_descr calls

["Darrick J. Wong" <djwong@kernel.org>]

On Fri, Jan 23, 2026 at 06:33:23AM +0100, Christoph Hellwig wrote:
> On Thu, Jan 22, 2026 at 10:57:01AM -0800, Darrick J. Wong wrote:
> > > > Alternately we just drop all the helpers and kasprintf crap in favor of
> > > > feeding the raw string ("iunlinked next pointers") all the way through
> > > > to shmem_kernel_file_setup.
> > > 
> > > But wouldn't we get duplicate names for different inodes?
> > 
> > Yes, but that's only used for readlink of /proc/$pid/fd/* so (AFAICT) it
> > makes tracing more confusing but doesn't affect functionality.
> > xfs_healthmon just passes in "xfs_healthmon" and I can run healers on
> > multiple filesystems just fine.
> > 
> > anon inodes are ... uh ... magic.
> 
> Ok, that certainly would simply things a lot, and I'd be ok with it.
> 
> My ideas didn't really work out.  The last idea I had was to be able
> to specify a prefix in a new method in struct xchk_meta_ops, but
> this starts to feel like severe overengineering.

<nod> I just replaced them with static strings and everything seemed to
work fine.  Will send a replacement patchset shortly.

--D