[PATCH] drm/tyr: depend on `COMMON_CLK` to fix build error

[PATCH] drm/tyr: depend on `COMMON_CLK` to fix build error

[Miguel Ojeda]

Tyr needs `CONFIG_COMMON_CLK` to build:

    error[E0432]: unresolved import `kernel::clk::Clk`
     --> drivers/gpu/drm/tyr/driver.rs:3:5
      |
    3 | use kernel::clk::Clk;
      |     ^^^^^^^^^^^^^^^^ no `Clk` in `clk`

    error[E0432]: unresolved import `kernel::clk::OptionalClk`
     --> drivers/gpu/drm/tyr/driver.rs:4:5
      |
    4 | use kernel::clk::OptionalClk;
      |     ^^^^^^^^^^^^^^^^^^^^^^^^ no `OptionalClk` in `clk`

Thus add the dependency to fix it.

Fixes: cf4fd52e3236 ("rust: drm: Introduce the Tyr driver for Arm Mali GPUs")
Cc: stable@vger.kernel.org
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
---
 drivers/gpu/drm/tyr/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/tyr/Kconfig b/drivers/gpu/drm/tyr/Kconfig
index 4b55308fd2eb..e933e6478027 100644
--- a/drivers/gpu/drm/tyr/Kconfig
+++ b/drivers/gpu/drm/tyr/Kconfig
@@ -6,6 +6,7 @@ config DRM_TYR
 	depends on RUST
 	depends on ARM || ARM64 || COMPILE_TEST
 	depends on !GENERIC_ATOMIC64  # for IOMMU_IO_PGTABLE_LPAE
+	depends on COMMON_CLK
 	default n
 	help
 	  Rust DRM driver for ARM Mali CSF-based GPUs.

base-commit: 24d479d26b25bce5faea3ddd9fa8f3a6c3129ea7
-- 
2.52.0

Re: [PATCH] drm/tyr: depend on `COMMON_CLK` to fix build error

[Alice Ryhl]

On Sat, Jan 24, 2026 at 5:13 PM Miguel Ojeda <ojeda@kernel.org> wrote:
>
> Tyr needs `CONFIG_COMMON_CLK` to build:
>
>     error[E0432]: unresolved import `kernel::clk::Clk`
>      --> drivers/gpu/drm/tyr/driver.rs:3:5
>       |
>     3 | use kernel::clk::Clk;
>       |     ^^^^^^^^^^^^^^^^ no `Clk` in `clk`
>
>     error[E0432]: unresolved import `kernel::clk::OptionalClk`
>      --> drivers/gpu/drm/tyr/driver.rs:4:5
>       |
>     4 | use kernel::clk::OptionalClk;
>       |     ^^^^^^^^^^^^^^^^^^^^^^^^ no `OptionalClk` in `clk`
>
> Thus add the dependency to fix it.
>
> Fixes: cf4fd52e3236 ("rust: drm: Introduce the Tyr driver for Arm Mali GPUs")
> Cc: stable@vger.kernel.org
> Signed-off-by: Miguel Ojeda <ojeda@kernel.org>

Thanks Miguel. Since the drm fixes PR for this week was already sent I
think we can just include this in drm-rust-next.

Though, if you plan a fixes PR for this cycle, you're also welcome to
include this patch with my ack.
Acked-by: Alice Ryhl <aliceryhl@google.com>

Alice

Re: [PATCH] drm/tyr: depend on `COMMON_CLK` to fix build error

[Miguel Ojeda]

On Sat, Jan 24, 2026 at 11:36 PM Alice Ryhl <aliceryhl@google.com> wrote:
>
> Thanks Miguel. Since the drm fixes PR for this week was already sent I
> think we can just include this in drm-rust-next.
>
> Though, if you plan a fixes PR for this cycle, you're also welcome to
> include this patch with my ack.
> Acked-by: Alice Ryhl <aliceryhl@google.com>

You're welcome!

Yeah, I am sending the fixes PR in a few days, so I can pick it up if
it is easier for you. Either way, it is not very urgent.

Cheers,
Miguel

Re: [PATCH] drm/tyr: depend on `COMMON_CLK` to fix build error

[Miguel Ojeda]

On Sat, Jan 24, 2026 at 5:13 PM Miguel Ojeda <ojeda@kernel.org> wrote:
>
> Tyr needs `CONFIG_COMMON_CLK` to build:
>
>     error[E0432]: unresolved import `kernel::clk::Clk`
>      --> drivers/gpu/drm/tyr/driver.rs:3:5
>       |
>     3 | use kernel::clk::Clk;
>       |     ^^^^^^^^^^^^^^^^ no `Clk` in `clk`
>
>     error[E0432]: unresolved import `kernel::clk::OptionalClk`
>      --> drivers/gpu/drm/tyr/driver.rs:4:5
>       |
>     4 | use kernel::clk::OptionalClk;
>       |     ^^^^^^^^^^^^^^^^^^^^^^^^ no `OptionalClk` in `clk`
>
> Thus add the dependency to fix it.
>
> Fixes: cf4fd52e3236 ("rust: drm: Introduce the Tyr driver for Arm Mali GPUs")
> Cc: stable@vger.kernel.org
> Signed-off-by: Miguel Ojeda <ojeda@kernel.org>

Applied to `rust-fixes` -- thanks!

Cheers,
Miguel

Re: [PATCH] drm/tyr: depend on `COMMON_CLK` to fix build error

[Alice Ryhl]

On Mon, Jan 26, 2026 at 4:10 AM Miguel Ojeda
<miguel.ojeda.sandonis@gmail.com> wrote:
>
> On Sat, Jan 24, 2026 at 5:13 PM Miguel Ojeda <ojeda@kernel.org> wrote:
> >
> > Tyr needs `CONFIG_COMMON_CLK` to build:
> >
> >     error[E0432]: unresolved import `kernel::clk::Clk`
> >      --> drivers/gpu/drm/tyr/driver.rs:3:5
> >       |
> >     3 | use kernel::clk::Clk;
> >       |     ^^^^^^^^^^^^^^^^ no `Clk` in `clk`
> >
> >     error[E0432]: unresolved import `kernel::clk::OptionalClk`
> >      --> drivers/gpu/drm/tyr/driver.rs:4:5
> >       |
> >     4 | use kernel::clk::OptionalClk;
> >       |     ^^^^^^^^^^^^^^^^^^^^^^^^ no `OptionalClk` in `clk`
> >
> > Thus add the dependency to fix it.
> >
> > Fixes: cf4fd52e3236 ("rust: drm: Introduce the Tyr driver for Arm Mali GPUs")
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
>
> Applied to `rust-fixes` -- thanks!

Thanks!