Re: [PATCH 1/2] media: qcom: camss: Fix pipeline lock leak in stop_streaming

[Greg KH <gregkh@linuxfoundation.org>]

On Sun, Jan 25, 2026 at 08:25:43PM +0530, Saikiran wrote:
> When a browser or application closes the camera, if any subdevice fails
> to stop streaming, video_stop_streaming() returns early without calling
> video_device_pipeline_stop(). This leaves the pipeline permanently locked,
> preventing any future camera access until reboot.
> 
> Fix this by logging errors but continuing to stop all remaining subdevices
> and always releasing the pipeline lock, even when errors occur during the
> stop sequence.
> 
> Fixes: 89013969e232 ("media: camss: sm8250: Pipeline starting and stopping for multiple virtual channels")
> Cc: stable@vger.kernel.org
> Tested-on: Lenovo Yoga Slim 7x (Snapdragon X Elite, ov02c10 camera)
> Signed-off-by: Saikiran <bjsaikiran@gmail.com>
> ---
>  drivers/media/platform/qcom/camss/camss-video.c | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/platform/qcom/camss/camss-video.c b/drivers/media/platform/qcom/camss/camss-video.c
> index 831486e14754..242c44f97801 100644
> --- a/drivers/media/platform/qcom/camss/camss-video.c
> +++ b/drivers/media/platform/qcom/camss/camss-video.c
> @@ -312,9 +312,15 @@ static void video_stop_streaming(struct vb2_queue *q)
>  
>  		ret = v4l2_subdev_call(subdev, video, s_stream, 0);
>  
> +		/*
> +		 * Don't return early on error - we must continue to stop
> +		 * remaining subdevices and release the pipeline lock to
> +		 * prevent the camera from being permanently locked.
> +		 */
>  		if (ret) {
> -			dev_err(video->camss->dev, "Video pipeline stop failed: %d\n", ret);
> -			return;
> +			dev_err(video->camss->dev,
> +				"Failed to stop subdev '%s': %d\n",
> +				subdev->name, ret);
>  		}
>  	}
>  
> -- 
> 2.51.0
> 
> 


<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read:
    https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

</formletter>