From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B002230DEC4; Wed, 28 Jan 2026 15:48:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769615316; cv=none; b=Cf7y37YG/5tlvPKY0Kx2PPKt31NZ7DTJFcuRcsHJwnHLVCNqeUkdf0Gspw6bPB+vLmBPw7dvjhM1I5z3A7Dly73bvDeTe6uKwt7CNHsO57+UtzuP6k1x9Y7CyowDaT+s7RugarLaXsIYlGNctulWcy3PiulUc1EYJKhKo/dXS5s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769615316; c=relaxed/simple; bh=ShfTXfzATBySTQ22lPxJ1FJf+2zLWcHi2AOw+tzWRLY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dcdIxSXlD4DXq/VlayBWgmm96NJoXjxKN7Hyn5XXgi3R0AfFUHEIlfZrAEzb8k1gOt06oi5XOg4DYzCi1ukWmQpiR2vTgsTkjRd9Vg5NSl+Z4py6e0NI8AKRbH8j0o6Djwtl8CYUcIvrQgTw1kL6xm93f9hMEGSm997/sdhVcMw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=W9YAFLE3; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="W9YAFLE3" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 17D84C4CEF1; Wed, 28 Jan 2026 15:48:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1769615316; bh=ShfTXfzATBySTQ22lPxJ1FJf+2zLWcHi2AOw+tzWRLY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=W9YAFLE3Pvx5fTQs/F6oAEyBJAvB4t62bA+Xhx3MhYmitumickElljiZE1Ukl/1ZZ pG4pvG0XcqaMrAawzRrX4BGVjPC8q0vle1/qGC5C1QGTfIEuKt/NtTTzSj3ho8QUbI rcxLVWA3nK8UDkHPFMdT8NIdkL9nnb7QEgSVc6hg= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Marc Kleine-Budde Subject: [PATCH 6.12 142/169] can: mcba_usb: mcba_usb_read_bulk_callback(): fix URB memory leak Date: Wed, 28 Jan 2026 16:23:45 +0100 Message-ID: <20260128145339.115473452@linuxfoundation.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260128145334.006287341@linuxfoundation.org> References: <20260128145334.006287341@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Marc Kleine-Budde commit 710a7529fb13c5a470258ff5508ed3c498d54729 upstream. Fix similar memory leak as in commit 7352e1d5932a ("can: gs_usb: gs_usb_receive_bulk_callback(): fix URB memory leak"). In mcba_usb_probe() -> mcba_usb_start(), the URBs for USB-in transfers are allocated, added to the priv->rx_submitted anchor and submitted. In the complete callback mcba_usb_read_bulk_callback(), the URBs are processed and resubmitted. In mcba_usb_close() -> mcba_urb_unlink() the URBs are freed by calling usb_kill_anchored_urbs(&priv->rx_submitted). However, this does not take into account that the USB framework unanchors the URB before the complete function is called. This means that once an in-URB has been completed, it is no longer anchored and is ultimately not released in usb_kill_anchored_urbs(). Fix the memory leak by anchoring the URB in the mcba_usb_read_bulk_callback()to the priv->rx_submitted anchor. Fixes: 51f3baad7de9 ("can: mcba_usb: Add support for Microchip CAN BUS Analyzer") Cc: stable@vger.kernel.org Link: https://patch.msgid.link/20260116-can_usb-fix-memory-leak-v2-4-4b8cb2915571@pengutronix.de Signed-off-by: Marc Kleine-Budde Signed-off-by: Greg Kroah-Hartman --- drivers/net/can/usb/mcba_usb.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) --- a/drivers/net/can/usb/mcba_usb.c +++ b/drivers/net/can/usb/mcba_usb.c @@ -608,11 +608,17 @@ resubmit_urb: urb->transfer_buffer, MCBA_USB_RX_BUFF_SIZE, mcba_usb_read_bulk_callback, priv); + usb_anchor_urb(urb, &priv->rx_submitted); + retval = usb_submit_urb(urb, GFP_ATOMIC); + if (!retval) + return; + + usb_unanchor_urb(urb); if (retval == -ENODEV) netif_device_detach(netdev); - else if (retval) + else netdev_err(netdev, "failed resubmitting read bulk urb: %d\n", retval); }