From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 760C92DF155; Wed, 28 Jan 2026 15:53:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769615634; cv=none; b=oWjHqXeF/BSV5uho0Mjw7zE1+uYUfGSFoJeJkenkpV6x0iyrC78KOCs00qVLedx18cMDjse9JYbIfNgJSyukq0kk8tlVRVT7bJZuPSYld+9n3qktW8IGu0fYqn9Ur/1FfjZFnAebVHNNNiNfY5Nksbcnc8scWF3iJVRZwxCAj1Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769615634; c=relaxed/simple; bh=pddhLI8eRhemip7B5xdwKYPYyoszIqE+24NV0BZukYE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=i8v4YKvdqXNx/VsP1dRD8WOZ2NwFaEsZC70JmFKvthGm0W6A+z8xFEOOhCBCZHCO9M/RRAeJXlZF75vriR1rwXGDEEr6nlgRAWgoqR+M89UBHWjhVrGBkrerPCI8vMipJnfz4ozbuknUZ3nSTlY2GuIRaUgKV37VP7BqMXX9qpU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=W9yrVnjW; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="W9yrVnjW" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B9929C116C6; Wed, 28 Jan 2026 15:53:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1769615634; bh=pddhLI8eRhemip7B5xdwKYPYyoszIqE+24NV0BZukYE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=W9yrVnjWUoyfwBnSUbba97n/Dbu0XtAuDB5A+bYyGl8AowJ8NJESOGq1FA5KkdYop FdfyZd2nq3r+Gq/uF14Kq0SKry34dwU0HhPcSmuTE696EN0d9Qt4ncgLXHj4b/lk5H Xvg0a9k+eaLRoeRVKrDGb2/La016QfwkwJ/ZonBs= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Raju Rangoju , Jakub Kicinski , Sasha Levin Subject: [PATCH 6.18 035/227] amd-xgbe: avoid misleading per-packet error log Date: Wed, 28 Jan 2026 16:21:20 +0100 Message-ID: <20260128145345.607461699@linuxfoundation.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260128145344.331957407@linuxfoundation.org> References: <20260128145344.331957407@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Raju Rangoju [ Upstream commit c158f985cf6c2c36c99c4f67af2ff3f5ebe09f8f ] On the receive path, packet can be damaged because of buffer overflow in Rx FIFO. Avoid misleading per-packet error log when packet->errors is set, this can flood the log. Instead, rely on the standard rtnl_link_stats64 stats. Fixes: c5aa9e3b8156 ("amd-xgbe: Initial AMD 10GbE platform driver") Signed-off-by: Raju Rangoju Link: https://patch.msgid.link/20260114163037.2062606-1-Raju.Rangoju@amd.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/amd/xgbe/xgbe-drv.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-drv.c b/drivers/net/ethernet/amd/xgbe/xgbe-drv.c index 4dc631af79332..ba5e728ae6308 100644 --- a/drivers/net/ethernet/amd/xgbe/xgbe-drv.c +++ b/drivers/net/ethernet/amd/xgbe/xgbe-drv.c @@ -1823,7 +1823,7 @@ static void xgbe_get_stats64(struct net_device *netdev, s->multicast = pstats->rxmulticastframes_g; s->rx_length_errors = pstats->rxlengtherror; s->rx_crc_errors = pstats->rxcrcerror; - s->rx_fifo_errors = pstats->rxfifooverflow; + s->rx_over_errors = pstats->rxfifooverflow; s->tx_packets = pstats->txframecount_gb; s->tx_bytes = pstats->txoctetcount_gb; @@ -2277,9 +2277,6 @@ static int xgbe_rx_poll(struct xgbe_channel *channel, int budget) goto read_again; if (error || packet->errors) { - if (packet->errors) - netif_err(pdata, rx_err, netdev, - "error in received packet\n"); dev_kfree_skb(skb); goto next_packet; } -- 2.51.0