From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D641081AA8; Wed, 28 Jan 2026 16:03:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769616186; cv=none; b=C5U0nmV3EVsSp0asO2kwXa6hSrFnkym8CBIaAGtjmsVQLrf1vTHbzwspZGlEijtztqjy2G/iLPtfx/X1Pu8/0G6/WVaMveNOBp/RZsANvPcp0R8L3nR7FMgpZoZM2NCOoMbRUcyl6XYwmC6cWkCkZQi+0kMwlfl/VXM3oQwfjlo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769616186; c=relaxed/simple; bh=Qwdqtz42dWwdRYyZrN4kBZ/LNj+N35d3UC+MhuFVIx8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qGX/zCCPZTuOD9JiO7jhrFPdtTrA8gqBt1jSWBt2bl6aAEJUSlq++ZGYxhoWs6fbn48ll8ixbj1pIqK2Z4kCOw6PCmFpZUpJf68YlHVPROcku10urZNyrNOwfe7pkgnO7H3lGNadNUYJZKcsa6G1/WU8TLiHmPmNwFaBzPowwsY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=mXBe9mdB; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="mXBe9mdB" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4A51AC4CEF1; Wed, 28 Jan 2026 16:03:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1769616186; bh=Qwdqtz42dWwdRYyZrN4kBZ/LNj+N35d3UC+MhuFVIx8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mXBe9mdBjNKm0DG00i/VRI4rspihTuoS0D47d6egPNEAsaofH1E/CnUiDQXNqMxGf JQOTrWaN5ehI4iv3PeLnX31pSaz3U2mBEK9gFbRxvoIGPNwB7te8zxdEnfsdXntZK/ sXfjbDCtW11b3y+nke459SSkF9kICVEeq9KPx8dc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Marc Kleine-Budde Subject: [PATCH 6.18 208/227] can: esd_usb: esd_usb_read_bulk_callback(): fix URB memory leak Date: Wed, 28 Jan 2026 16:24:13 +0100 Message-ID: <20260128145351.921361863@linuxfoundation.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260128145344.331957407@linuxfoundation.org> References: <20260128145344.331957407@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Marc Kleine-Budde commit 5a4391bdc6c8357242f62f22069c865b792406b3 upstream. Fix similar memory leak as in commit 7352e1d5932a ("can: gs_usb: gs_usb_receive_bulk_callback(): fix URB memory leak"). In esd_usb_open(), the URBs for USB-in transfers are allocated, added to the dev->rx_submitted anchor and submitted. In the complete callback esd_usb_read_bulk_callback(), the URBs are processed and resubmitted. In esd_usb_close() the URBs are freed by calling usb_kill_anchored_urbs(&dev->rx_submitted). However, this does not take into account that the USB framework unanchors the URB before the complete function is called. This means that once an in-URB has been completed, it is no longer anchored and is ultimately not released in esd_usb_close(). Fix the memory leak by anchoring the URB in the esd_usb_read_bulk_callback() to the dev->rx_submitted anchor. Fixes: 96d8e90382dc ("can: Add driver for esd CAN-USB/2 device") Cc: stable@vger.kernel.org Link: https://patch.msgid.link/20260116-can_usb-fix-memory-leak-v2-2-4b8cb2915571@pengutronix.de Signed-off-by: Marc Kleine-Budde Signed-off-by: Greg Kroah-Hartman --- drivers/net/can/usb/esd_usb.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) --- a/drivers/net/can/usb/esd_usb.c +++ b/drivers/net/can/usb/esd_usb.c @@ -541,13 +541,20 @@ resubmit_urb: urb->transfer_buffer, ESD_USB_RX_BUFFER_SIZE, esd_usb_read_bulk_callback, dev); + usb_anchor_urb(urb, &dev->rx_submitted); + err = usb_submit_urb(urb, GFP_ATOMIC); + if (!err) + return; + + usb_unanchor_urb(urb); + if (err == -ENODEV) { for (i = 0; i < dev->net_count; i++) { if (dev->nets[i]) netif_device_detach(dev->nets[i]->netdev); } - } else if (err) { + } else { dev_err(dev->udev->dev.parent, "failed resubmitting read bulk urb: %pe\n", ERR_PTR(err)); }