From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 288D5285C8D; Wed, 28 Jan 2026 16:02:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769616139; cv=none; b=rfVPfny+wMrh+y5J0vj5ITpcj9NE8m3nLkMCSnM8pGjaQYIuLiwllywXfsShWYiMeiaxzDO90r9uKQ9HlHIIkvwyZrYVZ7zj5nhxNGhyfXz2snw9GMDjMxer+z3ENgj+Ujwf/eNmNTP7lK+b5RhnjGgzbjDCZGzDowzrld5+BrY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769616139; c=relaxed/simple; bh=ECNYry+I+ctakyeQ1OEUoQKGGou1GNt6pVlU3HU0PrU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ArNdAv1xtH1LEQMV+J9raxS5fE39WV7NGUW05+cztYAu7Be3YWV3R0PXWFokXKZtfVXuLxK4068IwsTAmrilu/ta31qVHByCLfSIHuZJFE4GZQMpIvVGECOU7XTNfQXAylXSeI2XOmz8GfPV5YnqK5DnjcA4NDAu9oyV8RkiWg8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=oG2Q8B+w; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="oG2Q8B+w" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8BF57C4CEF7; Wed, 28 Jan 2026 16:02:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1769616139; bh=ECNYry+I+ctakyeQ1OEUoQKGGou1GNt6pVlU3HU0PrU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oG2Q8B+wqh4QhQX5jqiAhNxRhMwgbQAbC1pNhmmTv4VmqANDzpLOCUMUQbdrwtJPg xUgvg93pBsU0FNLQCT4ySk+luEiQrjx8H8ojL9wja0bbdq2pUwmP8BET9m6NzF2GNr 0lNwl1NxPv23T/i3S1mloXZfom3XEmH1wqjmY/T0= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Tzung-Bi Shih , Bartosz Golaszewski Subject: [PATCH 6.18 218/227] gpio: cdev: Fix resource leaks on errors in gpiolib_cdev_register() Date: Wed, 28 Jan 2026 16:24:23 +0100 Message-ID: <20260128145352.276855826@linuxfoundation.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260128145344.331957407@linuxfoundation.org> References: <20260128145344.331957407@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Tzung-Bi Shih commit 8a8c942cad4cd12f739a8bb60cac77fd173c4e07 upstream. On error handling paths, gpiolib_cdev_register() doesn't free the allocated resources which results leaks. Fix it. Cc: stable@vger.kernel.org Fixes: 7b9b77a8bba9 ("gpiolib: add a per-gpio_device line state notification workqueue") Fixes: d83cee3d2bb1 ("gpio: protect the pointer to gpio_chip in gpio_device with SRCU") Signed-off-by: Tzung-Bi Shih Link: https://lore.kernel.org/r/20260120092650.2305319-1-tzungbi@kernel.org Signed-off-by: Bartosz Golaszewski Signed-off-by: Greg Kroah-Hartman --- drivers/gpio/gpiolib-cdev.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) --- a/drivers/gpio/gpiolib-cdev.c +++ b/drivers/gpio/gpiolib-cdev.c @@ -2821,13 +2821,18 @@ int gpiolib_cdev_register(struct gpio_de return -ENOMEM; ret = cdev_device_add(&gdev->chrdev, &gdev->dev); - if (ret) + if (ret) { + destroy_workqueue(gdev->line_state_wq); return ret; + } guard(srcu)(&gdev->srcu); gc = srcu_dereference(gdev->chip, &gdev->srcu); - if (!gc) + if (!gc) { + cdev_device_del(&gdev->chrdev, &gdev->dev); + destroy_workqueue(gdev->line_state_wq); return -ENODEV; + } gpiochip_dbg(gc, "added GPIO chardev (%d:%d)\n", MAJOR(devt), gdev->id);