From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C1A082EDD62; Wed, 28 Jan 2026 15:39:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769614763; cv=none; b=ru+MO3aZsjO0/Gc3vQmnE9H2iLnf6AHAlBdVCzO9flWeA7Dfzn1lfj9mZ+5eGXZxUX9fY804Ut/zNcUO7CePm7Tmz7kdxRxfdfEuPF3jvKe2yjHV5NOnXrEXCRrGUD8wc3LIvLXpMQSBt2UedCe2zO0eos7eG4j6PQwM37LnjUs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769614763; c=relaxed/simple; bh=jl9ChSWD/f/dkJPtKFJlRsuqUfB4a2o1AlsYPtqhyYQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MMwVIMIeKpYCP8utFOVagzIoIq0mKrqJWRMOz6BjtvwneazT1Xabi2umwILIA3JbQ2Gnf2GwNqJbYcVz/tFcRXVaHQbdLmcs0bpUyipqyyfndzafy9WniuvUJ25Yjj2COrytkftfQjaAYKWaJaCFh8vooQf7pL2/oo7sFZx8GnQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=LUjolTYV; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="LUjolTYV" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 485DEC4CEF7; Wed, 28 Jan 2026 15:39:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1769614763; bh=jl9ChSWD/f/dkJPtKFJlRsuqUfB4a2o1AlsYPtqhyYQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LUjolTYVMDa2vSgEcqqfydi+cRL8aAGUnGDdMFYB2CTpqa0I7SJ8FTgBq0idE6Cci RBA9aBp0fktuodRt1vGtKUwfMf8AfseFgZXHQqYvBeujzkYAYFCOJnqRVjc/P+MmsE I9ajXSzA1kemeqtYm+OaiwVvTyx9OEns04DWw3S0= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Pierre-Yves MORDRET , Johan Hovold , Amelie Delaunay , Vinod Koul , Sasha Levin Subject: [PATCH 6.6 234/254] dmaengine: stm32: dmamux: fix OF node leak on route allocation failure Date: Wed, 28 Jan 2026 16:23:30 +0100 Message-ID: <20260128145353.210372173@linuxfoundation.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260128145344.698118637@linuxfoundation.org> References: <20260128145344.698118637@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Johan Hovold [ Upstream commit b1b590a590af13ded598e70f0b72bc1e515787a1 ] Make sure to drop the reference taken to the DMA master OF node also on late route allocation failures. Fixes: df7e762db5f6 ("dmaengine: Add STM32 DMAMUX driver") Cc: stable@vger.kernel.org # 4.15 Cc: Pierre-Yves MORDRET Signed-off-by: Johan Hovold Reviewed-by: Amelie Delaunay Link: https://patch.msgid.link/20251117161258.10679-12-johan@kernel.org Signed-off-by: Vinod Koul Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/dma/stm32-dmamux.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/drivers/dma/stm32-dmamux.c +++ b/drivers/dma/stm32-dmamux.c @@ -143,7 +143,7 @@ static void *stm32_dmamux_route_allocate ret = pm_runtime_resume_and_get(&pdev->dev); if (ret < 0) { spin_unlock_irqrestore(&dmamux->lock, flags); - goto error; + goto err_put_dma_spec_np; } spin_unlock_irqrestore(&dmamux->lock, flags); @@ -165,6 +165,8 @@ static void *stm32_dmamux_route_allocate return mux; +err_put_dma_spec_np: + of_node_put(dma_spec->np); error: clear_bit(mux->chan_id, dmamux->dma_inuse);