public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: patches@lists.linux.dev, stable@vger.kernel.org
Cc: Anatolii Shirykalov <pipocavsobake@gmail.com>,
	Mark Brown <broonie@kernel.org>, Sasha Levin <sashal@kernel.org>,
	keenplify@gmail.com, yuzuru_10@proton.me,
	oliver.schramm97@gmail.com, santesegabriel@gmail.com,
	talhah.peerbhai@gmail.com, alex.andries.aa@gmail.com,
	queler@gmail.com, bajahawradhi@gmail.com, zhangheng@kylinos.cn
Subject: [PATCH AUTOSEL 6.18-6.1] ASoC: amd: yc: Add ASUS ExpertBook PM1503CDA to quirks list
Date: Mon,  2 Feb 2026 16:46:01 -0500	[thread overview]
Message-ID: <20260202214643.212290-6-sashal@kernel.org> (raw)
In-Reply-To: <20260202214643.212290-1-sashal@kernel.org>

From: Anatolii Shirykalov <pipocavsobake@gmail.com>

[ Upstream commit 018b211b1d321a52ed8d8de74ce83ce52a2e1224 ]

Add ASUS ExpertBook PM1503CDA to the DMI quirks table to enable
internal DMIC support via the ACP6x machine driver.

Signed-off-by: Anatolii Shirykalov <pipocavsobake@gmail.com>
Link: https://patch.msgid.link/20260119145618.3171435-1-pipocavsobake@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---

LLM Generated explanations, may be completely bogus:

## Analysis of ASoC: amd: yc: Add ASUS ExpertBook PM1503CDA to quirks
list

### 1. COMMIT MESSAGE ANALYSIS

The commit message is clear and straightforward:
- **Purpose**: Add a new device (ASUS ExpertBook PM1503CDA) to the DMI
  quirks table
- **Goal**: Enable internal DMIC (Digital Microphone) support via the
  ACP6x machine driver
- **Tags present**: Signed-off-by (author and maintainer), Link to patch
  submission
- **No Fixes: or Cc: stable tags**: As expected for commits requiring
  manual review

The commit is submitted by an external contributor and accepted by Mark
Brown (the ASoC maintainer), indicating it has been reviewed.

### 2. CODE CHANGE ANALYSIS

The diff shows:
- **Single file changed**: `sound/soc/amd/yc/acp6x-mach.c`
- **Lines added**: 7 lines (one new DMI table entry)
- **Lines removed**: 0

The change adds a new entry to the `yc_acp_quirk_table[]` array:
```c
{
    .driver_data = &acp6x_card,
    .matches = {
        DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER INC."),
        DMI_MATCH(DMI_PRODUCT_NAME, "ASUS EXPERTBOOK PM1503CDA"),
    }
},
```

This is a **boilerplate DMI quirk entry** identical in structure to all
surrounding entries in the table. It simply associates this specific
ASUS laptop model with the `acp6x_card` driver data.

### 3. CLASSIFICATION

This commit falls squarely into the **"QUIRKS and WORKAROUNDS"**
exception category for stable backports:

- It adds a hardware-specific quirk for a device that needs special
  handling
- The driver already exists in stable trees (ACP6x AMD audio driver)
- Without this entry, the internal microphone on this laptop model does
  not work
- This is a **real hardware enablement fix** - users of this ASUS laptop
  cannot use their built-in microphone without it

### 4. SCOPE AND RISK ASSESSMENT

- **Size**: Minimal - 7 lines of trivial, templated code
- **Complexity**: None - exact copy of existing patterns in the same
  file
- **Files touched**: 1
- **Subsystem**: ASoC AMD audio driver (mature, stable)
- **Risk of regression**: **Extremely low**
  - The DMI matching only triggers on this specific laptop model
  - It cannot affect any other system
  - The `acp6x_card` driver data is already used by dozens of other
    entries

### 5. USER IMPACT

- **Who is affected**: Users of ASUS ExpertBook PM1503CDA laptops
  running Linux
- **Impact without the fix**: Internal microphone does not work
- **Impact with the fix**: Internal microphone works correctly
- **Severity**: Medium-high for affected users (audio input is a core
  feature)

This is a real-world hardware enablement issue. Users of this specific
laptop model cannot use their built-in microphone for video calls, voice
recording, etc. without this quirk entry.

### 6. STABILITY INDICATORS

- **Maintainer sign-off**: Mark Brown (ASoC subsystem maintainer)
  accepted the patch
- **Pattern**: This exact pattern has been used hundreds of times in
  this file and across the kernel
- **Testing**: Presumably tested by the submitter on their hardware
  (standard for device quirk submissions)

### 7. DEPENDENCY CHECK

- **Dependencies**: None - this is a self-contained table entry
- **Code existence in stable**: The ACP6x driver and this quirks table
  exist in all recent stable trees (6.1+, 6.6+, etc.)
- **Backport adjustments**: None needed - the code will apply cleanly as
  the table structure is identical

### SUMMARY

This commit is a textbook example of a **stable-appropriate DMI quirk
addition**:

1. ✅ **Obviously correct**: Follows exact pattern of 80+ other entries
   in the same table
2. ✅ **Fixes a real bug**: Enables non-functional hardware (internal
   microphone)
3. ✅ **Small and contained**: 7 lines, single file, no logic changes
4. ✅ **No new features**: Just enables existing driver for new hardware
5. ✅ **No new APIs**: Pure data addition
6. ✅ **Zero regression risk**: Only affects one specific laptop model
7. ✅ **Falls under documented exception**: Hardware quirks are
   explicitly allowed in stable

The benefit to users of this ASUS laptop model is significant (working
microphone), while the risk to all other systems is essentially zero
(the DMI match ensures no other system is affected).

**YES**

 sound/soc/amd/yc/acp6x-mach.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c
index bf4d9d3365617..fe6cc3c74991f 100644
--- a/sound/soc/amd/yc/acp6x-mach.c
+++ b/sound/soc/amd/yc/acp6x-mach.c
@@ -535,6 +535,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "15NBC1011"),
 		}
 	},
+	{
+		.driver_data = &acp6x_card,
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER INC."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "ASUS EXPERTBOOK PM1503CDA"),
+		}
+	},
 	{
 		.driver_data = &acp6x_card,
 		.matches = {
-- 
2.51.0


  parent reply	other threads:[~2026-02-02 21:46 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-02 21:45 [PATCH AUTOSEL 6.18-6.12] ALSA: hda/realtek - fixed speaker no sound Sasha Levin
2026-02-02 21:45 ` [PATCH AUTOSEL 6.18-5.10] ALSA: hda/realtek: Fix headset mic for TongFang X6AR55xU Sasha Levin
2026-02-02 21:45 ` [PATCH AUTOSEL 6.18] io_uring/rw: free potentially allocated iovec on cache put failure Sasha Levin
2026-02-02 21:45 ` [PATCH AUTOSEL 6.18-6.12] ALSA: hda/realtek: ALC269 fixup for Lenovo Yoga Book 9i 13IRU8 audio Sasha Levin
2026-02-02 21:46 ` [PATCH AUTOSEL 6.18] ALSA: usb-audio: Add delay quirk for MOONDROP Moonriver2 Ti Sasha Levin
2026-02-02 21:46 ` Sasha Levin [this message]
2026-02-02 21:46 ` [PATCH AUTOSEL 6.18-5.10] gpio: sprd: Change sprd_gpio lock to raw_spin_lock Sasha Levin
2026-02-02 21:46 ` [PATCH AUTOSEL 6.18-6.6] spi: hisi-kunpeng: Fixed the wrong debugfs node name in hisi_spi debugfs initialization Sasha Levin
2026-02-02 21:46 ` [PATCH AUTOSEL 6.18-6.1] ASoC: cs35l45: Corrects ASP_TX5 DAPM widget channel Sasha Levin
2026-02-02 21:46 ` [PATCH AUTOSEL 6.18-5.10] scsi: target: iscsi: Fix use-after-free in iscsit_dec_conn_usage_count() Sasha Levin
2026-02-02 21:46 ` [PATCH AUTOSEL 6.18-6.1] ALSA: hda/realtek: Add quirk for Inspur S14-G1 Sasha Levin
2026-02-02 21:46 ` [PATCH AUTOSEL 6.18] btrfs: fix Wmaybe-uninitialized warning in replay_one_buffer() Sasha Levin
2026-02-02 21:46 ` [PATCH AUTOSEL 6.18-5.10] scsi: target: iscsi: Fix use-after-free in iscsit_dec_session_usage_count() Sasha Levin
2026-02-02 21:46 ` [PATCH AUTOSEL 6.18] Revert "drm/amd/display: pause the workload setting in dm" Sasha Levin
2026-02-02 21:46 ` [PATCH AUTOSEL 6.18] btrfs: sync read disk super and set block size Sasha Levin
2026-02-02 21:46 ` [PATCH AUTOSEL 6.18-5.10] wifi: mac80211: don't increment crypto_tx_tailroom_needed_cnt twice Sasha Levin
2026-02-02 21:46 ` [PATCH AUTOSEL 6.18] spi: intel-pci: Add support for Nova Lake SPI serial flash Sasha Levin
2026-02-02 21:46 ` [PATCH AUTOSEL 6.18-6.12] btrfs: reject new transactions if the fs is fully read-only Sasha Levin
2026-02-02 21:46 ` [PATCH AUTOSEL 6.18] riscv: Use 64-bit variable for output in __get_user_asm Sasha Levin
2026-02-02 21:46 ` [PATCH AUTOSEL 6.18-6.6] regmap: maple: free entry on mas_store_gfp() failure Sasha Levin
2026-02-02 21:46 ` [PATCH AUTOSEL 6.18-6.6] wifi: mac80211: correctly check if CSA is active Sasha Levin
2026-02-02 21:46 ` [PATCH AUTOSEL 6.18-5.10] romfs: check sb_set_blocksize() return value Sasha Levin
2026-02-02 21:46 ` [PATCH AUTOSEL 6.18-5.10] wifi: cfg80211: Fix bitrate calculation overflow for HE rates Sasha Levin
2026-02-02 21:46 ` [PATCH AUTOSEL 6.18] tracing: Avoid possible signed 64-bit truncation Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260202214643.212290-6-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=alex.andries.aa@gmail.com \
    --cc=bajahawradhi@gmail.com \
    --cc=broonie@kernel.org \
    --cc=keenplify@gmail.com \
    --cc=oliver.schramm97@gmail.com \
    --cc=patches@lists.linux.dev \
    --cc=pipocavsobake@gmail.com \
    --cc=queler@gmail.com \
    --cc=santesegabriel@gmail.com \
    --cc=stable@vger.kernel.org \
    --cc=talhah.peerbhai@gmail.com \
    --cc=yuzuru_10@proton.me \
    --cc=zhangheng@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox