From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1DD6457C9F for ; Tue, 3 Feb 2026 20:32:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770150741; cv=none; b=jrJq1ZHoIXB2/obhwsghCb4HL7g9VYO8TWpcrsNydmmJV2Gn22xvNfebOp6SvXRFYm1YPK9MAftRMJEUoQdzNlbHrKmH52V+qJs82ViSpJ/AF64zPlOqmVC1WvcOzggZ2aK03/ZIAd5jLCJvcZ7DyG38StJos2V21Mf7W1vinB4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770150741; c=relaxed/simple; bh=WP0JUaz6+AeLGqKyMCtA/Z3v6OYlK87vn+7HJuEF8ow=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VDxTHF7SgjmfjxWIWzJcExKaCksfTFlC+G8KMlqWpdhmg7JqkOP7G6oxI9t1H55hSCThqzSYEKuAiDXB42tgAHmKl+HtMle6DmgzCkbF6FLiG4n81dS9arrlWbT1O7uCdLCCE+CNERRXTiBUJZUDNaFfV7sI5qDG+UkUlb+Qpio= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=BmtuGPIm; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BmtuGPIm" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 306DAC116D0; Tue, 3 Feb 2026 20:32:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1770150740; bh=WP0JUaz6+AeLGqKyMCtA/Z3v6OYlK87vn+7HJuEF8ow=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BmtuGPIm7VBwj67zqBwWhqXjA73cp4EErx+I+LcQq0sFLcXZGC8+RXj5SX5Mynqoo jdlHtrcFyVvFmaP9nt5oQLDNYyl0r6bgYkXCaozylihX8twiqwtF9aqcl2ndYcgChQ v2BPdRHBBpSkzhXCkTDgYrv8Uw9p7JFjBwRkl6AA0VVa3eIVNA+tdSe2rFozLyIauq ueG22ry1hS+yBoBrcwK8Nma8CSUIDQrYvfa0vg45dBm3nQZaV1rUc4X1V2IpHYp9J+ 1HQjQ2CmtTlioHkF3lFmGST74G8UXxqaHE8XDR0W1LGAWn6VykC6e7JQDr+VyJhrhn pjI9TlWKiYUIw== From: Sasha Levin To: stable@vger.kernel.org Cc: Laveesh Bansal , Jan Kara , Christian Brauner , Sasha Levin Subject: [PATCH 5.10.y] writeback: fix 100% CPU usage when dirtytime_expire_interval is 0 Date: Tue, 3 Feb 2026 15:32:17 -0500 Message-ID: <20260203203217.1392938-1-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <2026020306-pretzel-ounce-b600@gregkh> References: <2026020306-pretzel-ounce-b600@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Laveesh Bansal [ Upstream commit 543467d6fe97e27e22a26e367fda972dbefebbff ] When vm.dirtytime_expire_seconds is set to 0, wakeup_dirtytime_writeback() schedules delayed work with a delay of 0, causing immediate execution. The function then reschedules itself with 0 delay again, creating an infinite busy loop that causes 100% kworker CPU usage. Fix by: - Only scheduling delayed work in wakeup_dirtytime_writeback() when dirtytime_expire_interval is non-zero - Cancelling the delayed work in dirtytime_interval_handler() when the interval is set to 0 - Adding a guard in start_dirtytime_writeback() for defensive coding Tested by booting kernel in QEMU with virtme-ng: - Before fix: kworker CPU spikes to ~73% - After fix: CPU remains at normal levels - Setting interval back to non-zero correctly resumes writeback Fixes: a2f4870697a5 ("fs: make sure the timestamps for lazytime inodes eventually get written") Cc: stable@vger.kernel.org Closes: https://bugzilla.kernel.org/show_bug.cgi?id=220227 Signed-off-by: Laveesh Bansal Link: https://patch.msgid.link/20260106145059.543282-2-laveeshb@laveeshbansal.com Reviewed-by: Jan Kara Signed-off-by: Christian Brauner [ adapted system_percpu_wq to system_wq for the workqueue used in dirtytime_interval_handler() ] Signed-off-by: Sasha Levin --- fs/fs-writeback.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c index ba70508b405d2..f464c9da7bc6a 100644 --- a/fs/fs-writeback.c +++ b/fs/fs-writeback.c @@ -2187,12 +2187,14 @@ static void wakeup_dirtytime_writeback(struct work_struct *w) wb_wakeup(wb); } rcu_read_unlock(); - schedule_delayed_work(&dirtytime_work, dirtytime_expire_interval * HZ); + if (dirtytime_expire_interval) + schedule_delayed_work(&dirtytime_work, dirtytime_expire_interval * HZ); } static int __init start_dirtytime_writeback(void) { - schedule_delayed_work(&dirtytime_work, dirtytime_expire_interval * HZ); + if (dirtytime_expire_interval) + schedule_delayed_work(&dirtytime_work, dirtytime_expire_interval * HZ); return 0; } __initcall(start_dirtytime_writeback); @@ -2203,8 +2205,12 @@ int dirtytime_interval_handler(struct ctl_table *table, int write, int ret; ret = proc_dointvec_minmax(table, write, buffer, lenp, ppos); - if (ret == 0 && write) - mod_delayed_work(system_wq, &dirtytime_work, 0); + if (ret == 0 && write) { + if (dirtytime_expire_interval) + mod_delayed_work(system_wq, &dirtytime_work, 0); + else + cancel_delayed_work_sync(&dirtytime_work); + } return ret; } -- 2.51.0