From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0FD0832827A for ; Tue, 3 Feb 2026 23:29:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770161387; cv=none; b=JI3jhVg8q5+AF2mUCvW0kJaB6lmoPQ5MKm0dmRwEl1iljxS89A1bgUOIn/eqbwWnpRImoXga2gmuEc7p6oG7HK738V0WKBVDxzfYxgzd4xWIQQK9Kdob9qcTvaxiJlu01klihWycn950IQ85e7PqxlmrL1H7z+VKWIuZnHbKkcs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770161387; c=relaxed/simple; bh=cbDwtLisb6o4dHX/X41bX+gX2IIPazd7/d/A6FnAfG8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hIYT3zGCcPaNNDZ7BfAdW0iTNd9Wjcta9fWKBEngskWKW0RLi5w5Ip8VukMTbmEwkw1HJAYYnh0Tnlb2jSJvfMtszPzOk2fUxbMyZDnhhj5GKdDRc4O3OYMUPXMDHJj7Y/PjKcLg/mzVYUIgvSuF5LfmmP64vHWVsEP3JJ+TOp4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=uG+htvb7; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="uG+htvb7" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1DC94C19422; Tue, 3 Feb 2026 23:29:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1770161386; bh=cbDwtLisb6o4dHX/X41bX+gX2IIPazd7/d/A6FnAfG8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uG+htvb7/mpKYNdzMFdIpIIoAp7GvABT4ddKrtk/fqixD8hg/DP7EM8bb8eeWuqx3 d9Qyy4XEx6eUapPJ/zcxn7/yLYwrn75n/QzV+pwrymzu6hIajJP+p2khydIIP0Ilfc OFUE/5fzlGBuzCPKSvT3P9W5SoUa/hT4e8Xxbt4mmwMSB9/mjutddTcA2WMRYzX3Eh EuqM9Fgfgvr3UNRtwMRCow1XCII4BaC9k7/1e26t6OKPrMqkB2nsM0PvQevUr82rzj 2xLr2iA3VYqoY/Qvg5GFq9ICvb8bCpe+7LRJagHSt0by1GReOeq3mngVGBle8bsf81 0LRMHsiJvDjfw== From: Sasha Levin To: stable@vger.kernel.org Cc: Bartosz Golaszewski , Abel Vesa , Konrad Dybcio , Abel Vesa , Linus Walleij , Sasha Levin Subject: [PATCH 6.6.y] pinctrl: lpass-lpi: implement .get_direction() for the GPIO driver Date: Tue, 3 Feb 2026 18:29:44 -0500 Message-ID: <20260203232944.1435982-1-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <2026020308-amuck-amber-53e5@gregkh> References: <2026020308-amuck-amber-53e5@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Bartosz Golaszewski [ Upstream commit 4f0d22ec60cee420125f4055af76caa0f373a3fe ] GPIO controller driver should typically implement the .get_direction() callback as GPIOLIB internals may try to use it to determine the state of a pin. Add it for the LPASS LPI driver. Reported-by: Abel Vesa Cc: stable@vger.kernel.org Fixes: 6e261d1090d6 ("pinctrl: qcom: Add sm8250 lpass lpi pinctrl driver") Signed-off-by: Bartosz Golaszewski Reviewed-by: Konrad Dybcio Tested-by: Konrad Dybcio # X1E CRD Tested-by: Abel Vesa Signed-off-by: Linus Walleij [ PIN_CONFIG_LEVEL => PIN_CONFIG_OUTPUT ] Signed-off-by: Sasha Levin --- drivers/pinctrl/qcom/pinctrl-lpass-lpi.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c b/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c index 2b32da357af37..a17c71b3bc8b5 100644 --- a/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c +++ b/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c @@ -279,6 +279,22 @@ static const struct pinconf_ops lpi_gpio_pinconf_ops = { .pin_config_group_set = lpi_config_set, }; +static int lpi_gpio_get_direction(struct gpio_chip *chip, unsigned int pin) +{ + unsigned long config = pinconf_to_config_packed(PIN_CONFIG_OUTPUT, 0); + struct lpi_pinctrl *state = gpiochip_get_data(chip); + unsigned long arg; + int ret; + + ret = lpi_config_get(state->ctrl, pin, &config); + if (ret) + return ret; + + arg = pinconf_to_config_argument(config); + + return arg ? GPIO_LINE_DIRECTION_OUT : GPIO_LINE_DIRECTION_IN; +} + static int lpi_gpio_direction_input(struct gpio_chip *chip, unsigned int pin) { struct lpi_pinctrl *state = gpiochip_get_data(chip); @@ -377,6 +393,7 @@ static void lpi_gpio_dbg_show(struct seq_file *s, struct gpio_chip *chip) #endif static const struct gpio_chip lpi_gpio_template = { + .get_direction = lpi_gpio_get_direction, .direction_input = lpi_gpio_direction_input, .direction_output = lpi_gpio_direction_output, .get = lpi_gpio_get, -- 2.51.0