From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE24A329C7D for ; Tue, 3 Feb 2026 23:29:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770161389; cv=none; b=aE6rDOyW+CqUNFpTCqGFCK0p2rZfKUMFEVk03dOlQLL0nobG8Ej73ad0o8kgEXW/b5GO7fm5JETSrlBKXp37+fA4OreABwG86qIme3BizIlqqBFl73WRD2N8a1d2xxJlT49yezlPuRu1s8imhjepR6PyCeVhYZ3lwH7mvDssff8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770161389; c=relaxed/simple; bh=80VGc1uERbfHrB1iJVYzJxxnPzRKIALqVENFNQmIG9g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tq5rzKuU74Cax+QfsW1dB5zFDm2yNEoRJ6gPJ1SKiEb2magYtyIr0325HzNeuBjI5krpGck49i44e9xj3MzIxltUzb9vhOxRnmdm+dOE1jrvrQNCFa0YzCgV44rSKepkh9t0aaDkOdYBg+MZGiIc1KozJP+H7PttCVQiLum/12A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=T/QhJhMn; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="T/QhJhMn" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D086CC19422; Tue, 3 Feb 2026 23:29:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1770161389; bh=80VGc1uERbfHrB1iJVYzJxxnPzRKIALqVENFNQmIG9g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=T/QhJhMncG90Ymz9MYwY/6OGXJ4rI+j863Y3JgP/275be8sfSbU/svD61c4KxCTl7 zA+VPwDpu/0PP+H+ZyAcvmKSsjHNP2hMPX9J8Yi4Q7OyQmkWZejuf+hHg9LDUUI7KG QK8ZGzYFcKqL8L1dyu7cisj3Za0fnWOc3vMW47wckKrDCkFhSLp8hdy/apBY7MzZ4x qwXn98288LwyZRmDRplGB2ZX/oPjWQuYU5S39Po94QPGS8xlkp53hVR+rE2Cnhjv0U I96dZFfbb+kk3+BP6zEQ7AwsutWa5hdN6NZdfnkntfGCDT3u346Hmp8uY5O9A8ExzK gSkXGZmogfijQ== From: Sasha Levin To: stable@vger.kernel.org Cc: Johan Hovold , Philipp Zabel , Frank Li , Maxime Ripard , Sasha Levin Subject: [PATCH 6.1.y] drm/imx/tve: fix probe device leak Date: Tue, 3 Feb 2026 18:29:47 -0500 Message-ID: <20260203232947.1436026-1-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <2026020322-mascot-usage-c825@gregkh> References: <2026020322-mascot-usage-c825@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Johan Hovold [ Upstream commit e535c23513c63f02f67e3e09e0787907029efeaf ] Make sure to drop the reference taken to the DDC device during probe on probe failure (e.g. probe deferral) and on driver unbind. Fixes: fcbc51e54d2a ("staging: drm/imx: Add support for Television Encoder (TVEv2)") Cc: stable@vger.kernel.org # 3.10 Cc: Philipp Zabel Reviewed-by: Frank Li Signed-off-by: Johan Hovold Link: https://patch.msgid.link/20251030163456.15807-1-johan@kernel.org Signed-off-by: Maxime Ripard Signed-off-by: Sasha Levin --- drivers/gpu/drm/imx/imx-tve.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/drivers/gpu/drm/imx/imx-tve.c b/drivers/gpu/drm/imx/imx-tve.c index ab4d1c878fda3..f565975676841 100644 --- a/drivers/gpu/drm/imx/imx-tve.c +++ b/drivers/gpu/drm/imx/imx-tve.c @@ -522,6 +522,13 @@ static const struct component_ops imx_tve_ops = { .bind = imx_tve_bind, }; +static void imx_tve_put_device(void *_dev) +{ + struct device *dev = _dev; + + put_device(dev); +} + static int imx_tve_probe(struct platform_device *pdev) { struct device *dev = &pdev->dev; @@ -543,6 +550,12 @@ static int imx_tve_probe(struct platform_device *pdev) if (ddc_node) { tve->ddc = of_find_i2c_adapter_by_node(ddc_node); of_node_put(ddc_node); + if (tve->ddc) { + ret = devm_add_action_or_reset(dev, imx_tve_put_device, + &tve->ddc->dev); + if (ret) + return ret; + } } tve->mode = of_get_tve_mode(np); -- 2.51.0