From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3631F3ACA76 for ; Tue, 3 Feb 2026 14:48:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770130138; cv=none; b=ub2l8EVs+SX89YIqOF10+PZcPug0Da+nQn4wv5wu11vdA5DQE4GeHTyonxoj4X4GRuxPxU5NSB4+xfDiUnrHambuz3H851dCZqJJ2ahQwZKPNCB+bKh5MEPalFYGtc9p1noKWpWwWvXHsApz/rvZaEYjnG6ZPty5jk712xorQ4g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770130138; c=relaxed/simple; bh=HYOqQlVgAQ3xiFvWl/3QFlVIznHme4yIoupHUSb1/0A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SlKVK46gQHfpKoghd97vYsSqC+p4OR3+B05ukKEpsdLb2F5uoNPUslM8rJDnMEoF+kBm8PYKolW3mZMLVBXyc02wfs+6H4noPPS4Yy6HUMJf5EmWlrUz2Nbt/+8xpiVMqg8hoESawsyua/2QZSStHYKXttxa+06el9qe+dKjHDU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Urpp8iZV; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Urpp8iZV" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 70DFDC116D0; Tue, 3 Feb 2026 14:48:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1770130137; bh=HYOqQlVgAQ3xiFvWl/3QFlVIznHme4yIoupHUSb1/0A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Urpp8iZVco28HHlSlicNU1Fc80TEajPJNE2TXginbw6WUud6POfRksXPrsnIr9pC/ 4O9pQ/ZdTTBK+kJQNKS6FMVYR38yMBW2dMF3SLxWR4uFJboZYq+K87QFVtOAXgXLMs LqF4Gg4RSz4tELoEHCEpr3VV7xmIqDoyYD6uKzbY= Date: Tue, 3 Feb 2026 15:48:54 +0100 From: Greg KH To: Wentao Guan Cc: stable , tiwai , sashal , pavel Subject: Re: [PATCH 6.6] ALSA: usb-audio: Fix missing unlock at error path of maxpacksize check Message-ID: <2026020339-tidy-appealing-44f1@gregkh> References: Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Jan 30, 2026 at 06:04:44PM +0800, Wentao Guan wrote: > I found that patch which in v6.12.60 should be applied in v6.6-stable tree. > > From: Takashi Iwai > > The recent backport of the upstream commit 05a1fc5efdd8 ("ALSA: > usb-audio: Fix potential overflow of PCM transfer buffer") on the > older stable kernels like 6.12.y was broken since it doesn't consider > the mutex unlock, where the upstream code manages with guard(). > In the older code, we still need an explicit unlock. > > This is a fix that corrects the error path, applied only on old stable > trees. > > Reported-by: Pavel Machek > Closes: https://lore.kernel.org/aSWtH0AZH5+aeb+a@duo.ucw.cz > Fixes: 98e9d5e33bda ("ALSA: usb-audio: Fix potential overflow of PCM transfer buffer") > Reviewed-by: Pavel Machek > Signed-off-by: Takashi Iwai > Signed-off-by: Sasha Levin > (cherry picked from commit fdf0dc82eb60091772ecea73cbc5a8fb7562fc45) > Signed-off-by: Wentao Guan > --- > sound/usb/endpoint.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) This does not apply to the 6.6.y kernel tree :( Please fix up and resend. thanks, greg k-h