From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B7E720468E for ; Wed, 4 Feb 2026 00:39:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770165577; cv=none; b=f5uAfviiT6stExjB+rCjAU8WdrlLojLm13ES2jUyCZXC3NQx0gfJai88rE60gSVQgu6AtYdKPeUiHff2MIYcaz3J6ZtWJSel92LC1lPG+90FRmjA//dW2tz9g4o1nDwUkhvGAHmb9Ys7ZJXahDFlnonPGaNZ+QOhNldGCMDMhAI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770165577; c=relaxed/simple; bh=uCua0Ekv4SheXngsbH/dwuDjM2ng+NjC/1AOqZN1UY8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EWTf6Y9MB4tSNE8itqdn4CPTluAG8svz7JRKclGHbJ+q9/Z7qAJ5f0S2bWfaBvMu+iZ2JEGgKVIRDmXnc3tvySawgt/yHeeCdn5swNJAEuxYSiVdsPnUZX91q4IKnzSU0P+wvZVWSVEq2eDBQABFiw7uBTJdd3ndr6baPJFcUPc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=L3ZdehME; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="L3ZdehME" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 59134C2BC86; Wed, 4 Feb 2026 00:39:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1770165577; bh=uCua0Ekv4SheXngsbH/dwuDjM2ng+NjC/1AOqZN1UY8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=L3ZdehMElqYvEO2seiYdTLEDnFsG7cSRl2GViesQKjzbqZb+uzHpy2OTQasQ7YPgm hkKKgVgbcx4qEGpnUyX1TaMggZUZNOGBLR95IBe4HC6ROASqV3XgZZwolXLjGEfxhR ulsX2kNd4TLIO0ctLw4Wf30L7fVZnQqfch3MZOaGKCjRINeXDw9PalLe/dazhB8K7+ iSpJDgZHBa6XjCyJOoYJto/g/vPg2hpo3i68dg+MlFe4Wie6tiftyNmjyOb3fzFHIc /JNgDWFHTCmmMSvmD6X/h5Lc7Dwbbd0mkcknlc71CTcHewYXflvdEztbPdMTSGphQt thWI4G7QcQlaA== From: Sasha Levin To: stable@vger.kernel.org Cc: Johan Hovold , Philipp Zabel , Frank Li , Maxime Ripard , Sasha Levin Subject: [PATCH 5.10.y 3/3] drm/imx/tve: fix probe device leak Date: Tue, 3 Feb 2026 19:39:33 -0500 Message-ID: <20260204003933.1467160-3-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260204003933.1467160-1-sashal@kernel.org> References: <2026020324-unsure-backfield-4511@gregkh> <20260204003933.1467160-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Johan Hovold [ Upstream commit e535c23513c63f02f67e3e09e0787907029efeaf ] Make sure to drop the reference taken to the DDC device during probe on probe failure (e.g. probe deferral) and on driver unbind. Fixes: fcbc51e54d2a ("staging: drm/imx: Add support for Television Encoder (TVEv2)") Cc: stable@vger.kernel.org # 3.10 Cc: Philipp Zabel Reviewed-by: Frank Li Signed-off-by: Johan Hovold Link: https://patch.msgid.link/20251030163456.15807-1-johan@kernel.org Signed-off-by: Maxime Ripard Signed-off-by: Sasha Levin --- drivers/gpu/drm/imx/imx-tve.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/drivers/gpu/drm/imx/imx-tve.c b/drivers/gpu/drm/imx/imx-tve.c index 8c16b0579e568..e21b78eadea3c 100644 --- a/drivers/gpu/drm/imx/imx-tve.c +++ b/drivers/gpu/drm/imx/imx-tve.c @@ -517,6 +517,13 @@ static const struct component_ops imx_tve_ops = { .bind = imx_tve_bind, }; +static void imx_tve_put_device(void *_dev) +{ + struct device *dev = _dev; + + put_device(dev); +} + static int imx_tve_probe(struct platform_device *pdev) { struct device *dev = &pdev->dev; @@ -539,6 +546,12 @@ static int imx_tve_probe(struct platform_device *pdev) if (ddc_node) { tve->ddc = of_find_i2c_adapter_by_node(ddc_node); of_node_put(ddc_node); + if (tve->ddc) { + ret = devm_add_action_or_reset(dev, imx_tve_put_device, + &tve->ddc->dev); + if (ret) + return ret; + } } tve->mode = of_get_tve_mode(np); -- 2.51.0