From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B8A4523875D; Wed, 4 Feb 2026 14:48:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770216503; cv=none; b=l5ENXcjfucJRKpzsL2w12JpiY4BS68jcfp2t9i/zvcIFASfxLpPUNZdMoM2Bf65lPAv/8dbNR4A1fqOjP9Q/ohKXIqRsbcx2edqyXJQWjDqjbO4nofhuH2SfwrTwHtJiKP3Z/pjXJ5rrAVtIIB4oJuKQf/9MtHObVC8AGoLz2Bs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770216503; c=relaxed/simple; bh=8EUTk0Evkxy9Bet55DE8V3aQiE2Y/2cwwwMOM8VcUTc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JnX2h21gEar9N5y8vHdSuW33ohAtnTo8zDwMklyJTrFer7Y+wHNM5MFqGGXmaLJQGqpd5SKrV5XYZ7lB8roqbLb30iOLn5Htr2TTKiJ3r7J/aCFswc+i/7GtE6gTbkL9roIPecebg3nw7gTSyyArY3QCJN/xu5SBq1RzmNvQpNw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=u+49LiMP; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="u+49LiMP" Received: by smtp.kernel.org (Postfix) with ESMTPSA id F38C6C4CEF7; Wed, 4 Feb 2026 14:48:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1770216503; bh=8EUTk0Evkxy9Bet55DE8V3aQiE2Y/2cwwwMOM8VcUTc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=u+49LiMPOX8dmer4+36ZYCOdfd9dX5WsYj9cBHqKZeFxtRHlu7TwSlnw/hwbN8faF cVT0Fd4jX1/5/fiv6WL/OLReETpj+IEiZzkYOmwmd/a3Kgh9qpoShdecezucxqDxoT /Ktk6lChQbwtMaeYUUkog88Gt9+IBkpI0S340dGE= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Marc Kleine-Budde Subject: [PATCH 5.10 108/161] can: ems_usb: ems_usb_read_bulk_callback(): fix URB memory leak Date: Wed, 4 Feb 2026 15:39:31 +0100 Message-ID: <20260204143855.630756368@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260204143851.755002596@linuxfoundation.org> References: <20260204143851.755002596@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Marc Kleine-Budde commit 0ce73a0eb5a27070957b67fd74059b6da89cc516 upstream. Fix similar memory leak as in commit 7352e1d5932a ("can: gs_usb: gs_usb_receive_bulk_callback(): fix URB memory leak"). In ems_usb_open(), the URBs for USB-in transfers are allocated, added to the dev->rx_submitted anchor and submitted. In the complete callback ems_usb_read_bulk_callback(), the URBs are processed and resubmitted. In ems_usb_close() the URBs are freed by calling usb_kill_anchored_urbs(&dev->rx_submitted). However, this does not take into account that the USB framework unanchors the URB before the complete function is called. This means that once an in-URB has been completed, it is no longer anchored and is ultimately not released in ems_usb_close(). Fix the memory leak by anchoring the URB in the ems_usb_read_bulk_callback() to the dev->rx_submitted anchor. Fixes: 702171adeed3 ("ems_usb: Added support for EMS CPC-USB/ARM7 CAN/USB interface") Cc: stable@vger.kernel.org Link: https://patch.msgid.link/20260116-can_usb-fix-memory-leak-v2-1-4b8cb2915571@pengutronix.de Signed-off-by: Marc Kleine-Budde Signed-off-by: Greg Kroah-Hartman --- drivers/net/can/usb/ems_usb.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) --- a/drivers/net/can/usb/ems_usb.c +++ b/drivers/net/can/usb/ems_usb.c @@ -479,11 +479,17 @@ resubmit_urb: urb->transfer_buffer, RX_BUFFER_SIZE, ems_usb_read_bulk_callback, dev); + usb_anchor_urb(urb, &dev->rx_submitted); + retval = usb_submit_urb(urb, GFP_ATOMIC); + if (!retval) + return; + + usb_unanchor_urb(urb); if (retval == -ENODEV) netif_device_detach(netdev); - else if (retval) + else netdev_err(netdev, "failed resubmitting read bulk urb: %d\n", retval); }