From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92EC741B376; Wed, 4 Feb 2026 14:52:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770216755; cv=none; b=AFIP33mWaUIZCEV/mIIRfd/MiQO5ADz0pJat6Du6/KyubgL4ujHypPZAMkK7GWS+1TU4uFS64DwaAKm1Kbe43KJz7UVVUmHeWrAVcLFpiXHHoslLOGoSG5Fa9lcpDwsaVPbVwfis1Z4RNgrEJZG4mPW+OCRsvlfxHQzYH0KkSpo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770216755; c=relaxed/simple; bh=Ckfx0r12ShjgKanOO67dLHEUBZG6jMGSowyuVJTa7sM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NtMxlodKOEtqWyR7TOrERHgD24bEPhGxxs0vfaM21SdKJDyJErWM0YjC1ZjR7je+KtufgaMIzqhjF6XLI2wpOe/yGR317zpqxgvbq+1lg6MhBGlsL5VthSuyf1BSDzqyeWb415i2tc+bv9LlCco9TXCla/HOSxLbuGVEQk3ToTQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Yj1lkMHf; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Yj1lkMHf" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 09645C116C6; Wed, 4 Feb 2026 14:52:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1770216755; bh=Ckfx0r12ShjgKanOO67dLHEUBZG6jMGSowyuVJTa7sM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Yj1lkMHf+fMgf1w+KOihNBEZLU0rZOw9Az3dQl0YTineY0it5C34KYw82FfXFI3rI UBFbyHleDFSwXQ8yMrwwHwIx2hZOb3CxV81p6xxu/YB+QaqnWMX1E0sNcYGMfSCsk+ zBEZ9+bENfyQsiR/b8pBxHIDcK1MaIlvgotvDRdg= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Filipe Manana , Qu Wenruo , David Sterba , Sasha Levin Subject: [PATCH 5.15 005/206] btrfs: send: check for inline extents in range_is_hole_in_parent() Date: Wed, 4 Feb 2026 15:37:16 +0100 Message-ID: <20260204143858.392596933@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260204143858.193781818@linuxfoundation.org> References: <20260204143858.193781818@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Qu Wenruo [ Upstream commit 08b096c1372cd69627f4f559fb47c9fb67a52b39 ] Before accessing the disk_bytenr field of a file extent item we need to check if we are dealing with an inline extent. This is because for inline extents their data starts at the offset of the disk_bytenr field. So accessing the disk_bytenr means we are accessing inline data or in case the inline data is less than 8 bytes we can actually cause an invalid memory access if this inline extent item is the first item in the leaf or access metadata from other items. Fixes: 82bfb2e7b645 ("Btrfs: incremental send, fix unnecessary hole writes for sparse files") Reviewed-by: Filipe Manana Signed-off-by: Qu Wenruo Reviewed-by: David Sterba Signed-off-by: David Sterba Signed-off-by: Sasha Levin --- fs/btrfs/send.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c index a46076788bd7e..32992b2fdd384 100644 --- a/fs/btrfs/send.c +++ b/fs/btrfs/send.c @@ -5892,6 +5892,8 @@ static int range_is_hole_in_parent(struct send_ctx *sctx, extent_end = btrfs_file_extent_end(path); if (extent_end <= start) goto next; + if (btrfs_file_extent_type(leaf, fi) == BTRFS_FILE_EXTENT_INLINE) + return 0; if (btrfs_file_extent_disk_bytenr(leaf, fi) == 0) { search_start = extent_end; goto next; -- 2.51.0