From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D570257827; Wed, 4 Feb 2026 15:00:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770217217; cv=none; b=OGybIq8b1AepIKIEiojQ5yuhzE5N26BQ65X+AIT6K3W2pXvN9JwccvM3So4k65fq1X6qgYYcvSA/S0nQxsfgXh2/zdBINM+xUhkwJgy9GCSONjSfKjK0A0c77/NPWks5HzDz7Ml9STR3fP4MQ0ryaSCWkrflIMfHikD6GkryuGU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770217217; c=relaxed/simple; bh=6rJwR17qEVF0kPOHqwN2pwbbMBBx9TrCGFq/B1YXg/8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Y/fb87um3oleCMwNWQIY7ZkTfKru/oZarqbpdbuQd6qLPS4/ST4Wzlt+zJdBJ6mIQwM8N2aB10Q8FKtthJZwD+6RkJ2loyND+mPdaehgdfU0mlsEkuXbFc7TfVa1uoPBGkorthIsXJmIYUOfU1M4dSLJ++FDarHN4mJM/l4qJBg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=pr9Za01P; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="pr9Za01P" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B13DBC4CEF7; Wed, 4 Feb 2026 15:00:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1770217217; bh=6rJwR17qEVF0kPOHqwN2pwbbMBBx9TrCGFq/B1YXg/8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pr9Za01Po6FGl3lHyClP4nfGcmqTYOYMKbhrUZAAmSH1Ozp5vKt84kJeW98HHM7x1 wo233XIbjv0iT2ZnE78sobu8iGR0esHhFoWnSli1ODjueqrVNOsa+W5UUDj/TIPuBt gtUqj4xVpg6xSto/I30AHamhK5U19dVlaSEfrtsc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Marc Kleine-Budde Subject: [PATCH 5.15 131/206] can: usb_8dev: usb_8dev_read_bulk_callback(): fix URB memory leak Date: Wed, 4 Feb 2026 15:39:22 +0100 Message-ID: <20260204143902.917117590@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260204143858.193781818@linuxfoundation.org> References: <20260204143858.193781818@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Marc Kleine-Budde commit f7a980b3b8f80fe367f679da376cf76e800f9480 upstream. Fix similar memory leak as in commit 7352e1d5932a ("can: gs_usb: gs_usb_receive_bulk_callback(): fix URB memory leak"). In usb_8dev_open() -> usb_8dev_start(), the URBs for USB-in transfers are allocated, added to the priv->rx_submitted anchor and submitted. In the complete callback usb_8dev_read_bulk_callback(), the URBs are processed and resubmitted. In usb_8dev_close() -> unlink_all_urbs() the URBs are freed by calling usb_kill_anchored_urbs(&priv->rx_submitted). However, this does not take into account that the USB framework unanchors the URB before the complete function is called. This means that once an in-URB has been completed, it is no longer anchored and is ultimately not released in usb_kill_anchored_urbs(). Fix the memory leak by anchoring the URB in the usb_8dev_read_bulk_callback() to the priv->rx_submitted anchor. Fixes: 0024d8ad1639 ("can: usb_8dev: Add support for USB2CAN interface from 8 devices") Cc: stable@vger.kernel.org Link: https://patch.msgid.link/20260116-can_usb-fix-memory-leak-v2-5-4b8cb2915571@pengutronix.de Signed-off-by: Marc Kleine-Budde Signed-off-by: Greg Kroah-Hartman --- drivers/net/can/usb/usb_8dev.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) --- a/drivers/net/can/usb/usb_8dev.c +++ b/drivers/net/can/usb/usb_8dev.c @@ -544,11 +544,17 @@ resubmit_urb: urb->transfer_buffer, RX_BUFFER_SIZE, usb_8dev_read_bulk_callback, priv); + usb_anchor_urb(urb, &priv->rx_submitted); + retval = usb_submit_urb(urb, GFP_ATOMIC); + if (!retval) + return; + + usb_unanchor_urb(urb); if (retval == -ENODEV) netif_device_detach(netdev); - else if (retval) + else netdev_err(netdev, "failed resubmitting read bulk urb: %d\n", retval); }