From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 237C01E520C; Wed, 4 Feb 2026 15:13:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770218001; cv=none; b=BQ+WvHYii8j5D7I2UaJXwLigQa6iYm2Nlbr4qDHY+fyW9xG+Nv1KTLPMFtwvDGvr72nEkxfW1FQv6HmcwCWAUuiUaDr1RJbN47fk1/AKABhnuPWuIS2Hb/e3dofMMHGzqIsTdtUga14B2ZKPpKAt5HaewdB8gUSe1kGZLqBmO70= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770218001; c=relaxed/simple; bh=gzYGBU8NuBd28XYn45OLB0J+f2cstGwwn38/p7kmqfQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BAO5bpfI7nTRvyFubsVfiG3eEDejx7BxibosztaRyMIIx7rpvHIFhz2E0V29e6qnS2ocUK2zqqitvDeKJP3dxKVIE1qoucNhmVyM1GlLBUYdKmf8fDjQIa45lHEbisHFob3b2A2qTW/0V0K8SNTMBcaOOkoQLZ5SV83q9OeaRxk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=bEtv+Jb1; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="bEtv+Jb1" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 69027C116C6; Wed, 4 Feb 2026 15:13:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1770218000; bh=gzYGBU8NuBd28XYn45OLB0J+f2cstGwwn38/p7kmqfQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bEtv+Jb1/dWzFIONd8sJm+VbwAMPvk3HT2wBIv3WlTnWgLNl1N/Uc1Nk6W6F913ek UF1tXMTOzCWvuyEgbtruVFhQbNs1SYkNKwejOl0WQV5Bmh8JgFOsrQ3AXmw74nXd1C i983qfje4Q/48SMaHL8bEzyrhojv9C8GH4UE6Z/k= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Marc Kleine-Budde Subject: [PATCH 6.1 182/280] can: usb_8dev: usb_8dev_read_bulk_callback(): fix URB memory leak Date: Wed, 4 Feb 2026 15:39:16 +0100 Message-ID: <20260204143916.164838362@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260204143909.614719725@linuxfoundation.org> References: <20260204143909.614719725@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Marc Kleine-Budde commit f7a980b3b8f80fe367f679da376cf76e800f9480 upstream. Fix similar memory leak as in commit 7352e1d5932a ("can: gs_usb: gs_usb_receive_bulk_callback(): fix URB memory leak"). In usb_8dev_open() -> usb_8dev_start(), the URBs for USB-in transfers are allocated, added to the priv->rx_submitted anchor and submitted. In the complete callback usb_8dev_read_bulk_callback(), the URBs are processed and resubmitted. In usb_8dev_close() -> unlink_all_urbs() the URBs are freed by calling usb_kill_anchored_urbs(&priv->rx_submitted). However, this does not take into account that the USB framework unanchors the URB before the complete function is called. This means that once an in-URB has been completed, it is no longer anchored and is ultimately not released in usb_kill_anchored_urbs(). Fix the memory leak by anchoring the URB in the usb_8dev_read_bulk_callback() to the priv->rx_submitted anchor. Fixes: 0024d8ad1639 ("can: usb_8dev: Add support for USB2CAN interface from 8 devices") Cc: stable@vger.kernel.org Link: https://patch.msgid.link/20260116-can_usb-fix-memory-leak-v2-5-4b8cb2915571@pengutronix.de Signed-off-by: Marc Kleine-Budde Signed-off-by: Greg Kroah-Hartman --- drivers/net/can/usb/usb_8dev.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) --- a/drivers/net/can/usb/usb_8dev.c +++ b/drivers/net/can/usb/usb_8dev.c @@ -541,11 +541,17 @@ resubmit_urb: urb->transfer_buffer, RX_BUFFER_SIZE, usb_8dev_read_bulk_callback, priv); + usb_anchor_urb(urb, &priv->rx_submitted); + retval = usb_submit_urb(urb, GFP_ATOMIC); + if (!retval) + return; + + usb_unanchor_urb(urb); if (retval == -ENODEV) netif_device_detach(netdev); - else if (retval) + else netdev_err(netdev, "failed resubmitting read bulk urb: %d\n", retval); }