From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A3682D8798; Wed, 4 Feb 2026 15:16:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770218183; cv=none; b=eT4++JDRY1e8bUttlTJRbqPYfuMRlWt8vpGlXgTOrORjWejKaI+SVhya14nov0p5WPu0bBNYtiFerDhxToGn4q+mbMSWoP6yU6r7ZKRTyzLzOEWBJBfpi8LBcsTe9QMXa8fzlLLr48OPBiZGUk3XnaeXOeGKb2H8GE51gp5lUQM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770218183; c=relaxed/simple; bh=wNMa3y/Dm8dHnF/GSh8kei7z6goi3uYGgyTzpPvnok0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=K6RuD18BJ75YBXwm4t45ix88hW0LyRk6GcK5pydXIAara2h4brQmbKQwklorxLLeDV1fYw3FMh4I2s++W/ZomBAsc2UkLAvReLqko5SaSTizvfn75+Fw2Pb6eiIg5WrWLn7ylaq+fOjcaib7Xlo6rOdGoQxxSjQWcENnBkIQVcY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=pO+Tiii5; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="pO+Tiii5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 76391C4CEF7; Wed, 4 Feb 2026 15:16:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1770218183; bh=wNMa3y/Dm8dHnF/GSh8kei7z6goi3uYGgyTzpPvnok0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pO+Tiii5YqoLZAvvpjooUEg6HN8wMYOmfYJQXUcA/E7pQbEZac2A9GBMBUMWqtV2g nYpNaQ+d+vTMBEifSH+2oCSObT027+8LOJTCJkG8lH4QK37VbgQ/WKnRiBfrvg/DGS jhy5xuYT3lD5EvdN94w9DcJbpQYZif7Z41Vn1mGI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Tagir Garaev , Mark Brown , Sasha Levin Subject: [PATCH 6.1 203/280] ASoC: Intel: sof_es8336: fix headphone GPIO logic inversion Date: Wed, 4 Feb 2026 15:39:37 +0100 Message-ID: <20260204143916.907073892@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260204143909.614719725@linuxfoundation.org> References: <20260204143909.614719725@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Tagir Garaev [ Upstream commit 213c4e51267fd825cd21a08a055450cac7e0b7fb ] The headphone GPIO should be set to the inverse of speaker_en. When speakers are enabled, headphones should be disabled and vice versa. Currently both GPIOs are set to the same value (speaker_en), causing audio to play through both speakers and headphones simultaneously when headphones are plugged in. Tested on Huawei Matebook (BOD-WXX9) with ES8336 codec. Fixes: 6e1ff1459e00 ("ASoC: Intel: sof_es8336: support a separate gpio to control headphone") Signed-off-by: Tagir Garaev Link: https://patch.msgid.link/20260121152435.101698-1-tgaraev653@gmail.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/intel/boards/sof_es8336.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/intel/boards/sof_es8336.c b/sound/soc/intel/boards/sof_es8336.c index e22d767b6e97a..41dab5dcf79a3 100644 --- a/sound/soc/intel/boards/sof_es8336.c +++ b/sound/soc/intel/boards/sof_es8336.c @@ -120,7 +120,7 @@ static void pcm_pop_work_events(struct work_struct *work) gpiod_set_value_cansleep(priv->gpio_speakers, priv->speaker_en); if (quirk & SOF_ES8336_HEADPHONE_GPIO) - gpiod_set_value_cansleep(priv->gpio_headphone, priv->speaker_en); + gpiod_set_value_cansleep(priv->gpio_headphone, !priv->speaker_en); } -- 2.51.0