From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94C5E2BE03C; Wed, 4 Feb 2026 15:14:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770218098; cv=none; b=bAu1ztfdC6I6ORj/+PSpm8bFhI49/5/y0eJr+gZY4EdHdqJTTnl5DZ0ziwEVGilMnXmlJPAjKeTNUWEeBqsf/Q9cAOcd8eKwUoKisFkIyPYp2wpINFDtkczEACDH5tEHR30s5dBYPnGLlxbz91l2EZ1DmNOpdlv22e7rx/2XXZ0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770218098; c=relaxed/simple; bh=WLK4wQ4Tpz1a00GZZLipyOBUPgY2NSsrUWzhn1mQsOw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qK1qE6/CF2wfp5Dy1n+Wt7CyPL0jt8RJaPRWy+TIp45XgdGu+JiPLcA5KSzndgW1x81iujwGNB5h7jM5NS+3qaWXtn4vGUyzTrQOEom6VqVOmpgKSf6+Q/A5VW9bvVuwE3HgXU3H4JazGdAR/BjlAzrp34GtiDQxdZz7sG/BJiw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=UWzcKsY+; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="UWzcKsY+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0A2A2C4CEF7; Wed, 4 Feb 2026 15:14:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1770218098; bh=WLK4wQ4Tpz1a00GZZLipyOBUPgY2NSsrUWzhn1mQsOw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UWzcKsY+zrADAlsaqAgxPweSxNbKrbpduEm7vNAvrz1HDrKPQ2XW8Me79OYiKIRcm y+dw93qMLReToZeM9fvofWfVByJlCsOO8PE9B+7HkLMsQSW/LUZTSCGQf5O5Dm7EPW XL/h178aktiDLoB/U4L0k3e4o+0E/xOa4R9oCrLE= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Kohei Enju , Ard Biesheuvel Subject: [PATCH 6.1 212/280] efivarfs: fix error propagation in efivar_entry_get() Date: Wed, 4 Feb 2026 15:39:46 +0100 Message-ID: <20260204143917.238431314@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260204143909.614719725@linuxfoundation.org> References: <20260204143909.614719725@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Kohei Enju commit 4b22ec1685ce1fc0d862dcda3225d852fb107995 upstream. efivar_entry_get() always returns success even if the underlying __efivar_entry_get() fails, masking errors. This may result in uninitialized heap memory being copied to userspace in the efivarfs_file_read() path. Fix it by returning the error from __efivar_entry_get(). Fixes: 2d82e6227ea1 ("efi: vars: Move efivar caching layer into efivarfs") Cc: # v6.1+ Signed-off-by: Kohei Enju Signed-off-by: Ard Biesheuvel Signed-off-by: Greg Kroah-Hartman --- fs/efivarfs/vars.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/fs/efivarfs/vars.c +++ b/fs/efivarfs/vars.c @@ -609,7 +609,7 @@ int efivar_entry_get(struct efivar_entry err = __efivar_entry_get(entry, attributes, size, data); efivar_unlock(); - return 0; + return err; } /**