From: Greg KH <gregkh@linuxfoundation.org>
To: Nikunj A Dadhania <nikunj@amd.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, bp@alien8.de,
thomas.lendacky@amd.com, tglx@kernel.org, mingo@redhat.com,
dave.hansen@linux.intel.com, hpa@zytor.com, xin@zytor.com,
seanjc@google.com, pbonzini@redhat.com, x86@kernel.org,
jon.grimm@amd.com, stable@vger.kernel.org
Subject: Re: [PATCH] x86/fred: Fix early boot failures on SEV-ES/SNP guests
Date: Thu, 5 Feb 2026 06:56:59 +0100 [thread overview]
Message-ID: <2026020515-immovably-pacifism-2176@gregkh> (raw)
In-Reply-To: <20260205051030.1225975-1-nikunj@amd.com>
On Thu, Feb 05, 2026 at 05:10:30AM +0000, Nikunj A Dadhania wrote:
> @@ -70,6 +67,17 @@ void cpu_init_fred_exceptions(void)
> /* Use int $0x80 for 32-bit system calls in FRED mode */
> setup_clear_cpu_cap(X86_FEATURE_SYSFAST32);
> setup_clear_cpu_cap(X86_FEATURE_SYSCALL32);
> +
> + /*
> + * For secondary processors, FRED bit in CR4 gets enabled in cr4_init()
> + * and FRED MSRs are not configured till the end of this function. For
> + * SEV-ES and SNP guests, any console write before the FRED MSRs are
> + * setup will cause a #VC and cannot be handled. Move the pr_info to
> + * the end of this function.
> + *
> + * When FRED is enabled by default, remove this log message
> + */
> + pr_info("Initialized FRED on CPU%d\n", smp_processor_id());
Did you forget to fix this up?
Also, when the kernel is working properly, it is quiet, so why is this
log message needed?
thanks,
greg k-h
next prev parent reply other threads:[~2026-02-05 5:57 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-05 5:10 [PATCH] x86/fred: Fix early boot failures on SEV-ES/SNP guests Nikunj A Dadhania
2026-02-05 5:55 ` Greg KH
2026-02-05 6:10 ` Nikunj A. Dadhania
2026-02-05 6:20 ` Greg KH
2026-02-05 15:50 ` Sean Christopherson
2026-02-05 15:58 ` Dave Hansen
2026-02-05 16:00 ` Greg KH
2026-02-05 5:56 ` Greg KH [this message]
2026-02-05 6:24 ` Nikunj A. Dadhania
2026-02-05 7:11 ` Xin Li
2026-02-05 8:54 ` Nikunj A. Dadhania
2026-02-05 14:34 ` Xin Li
2026-02-05 10:41 ` kernel test robot
2026-02-06 3:31 ` Nikunj A. Dadhania
2026-02-06 9:34 ` Xin Li
2026-02-05 12:24 ` kernel test robot
2026-02-05 12:35 ` kernel test robot
2026-02-05 16:10 ` Dave Hansen
2026-02-05 17:20 ` Dave Hansen
2026-02-05 17:39 ` Tom Lendacky
2026-02-06 12:38 ` Nikunj A. Dadhania
2026-02-16 5:16 ` Nikunj A. Dadhania
2026-02-16 17:10 ` Dave Hansen
2026-02-19 19:27 ` Sohil Mehta
2026-02-19 20:22 ` Dave Hansen
2026-02-19 20:50 ` Sohil Mehta
2026-02-05 17:39 ` H. Peter Anvin
2026-02-06 12:12 ` Nikunj A. Dadhania
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026020515-immovably-pacifism-2176@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jon.grimm@amd.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=nikunj@amd.com \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=stable@vger.kernel.org \
--cc=tglx@kernel.org \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
--cc=xin@zytor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox