From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: "Oleksij Rempel" <o.rempel@pengutronix.de>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
stable@vger.kernel.org, kernel@pengutronix.de,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, "Andy Shevchenko" <andy@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"David Jander" <david@protonic.nl>
Subject: Re: [PATCH v5 01/13] iio: dac: ds4424: reject -128 RAW value
Date: Thu, 5 Feb 2026 20:14:07 +0000 [thread overview]
Message-ID: <20260205201407.7d6a6dfa@jic23-huawei> (raw)
In-Reply-To: <aYNUJyASwD67oOcN@smile.fi.intel.com>
On Wed, 4 Feb 2026 16:13:59 +0200
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> On Wed, Feb 04, 2026 at 03:00:33PM +0100, Oleksij Rempel wrote:
> > The DS442x DAC uses sign-magnitude encoding, so -128 cannot be represented
> > in hardware (7-bit magnitude).
> >
> > Previously, passing -128 resulted in a truncated value that programmed
> > 0mA (magnitude 0) instead of the expected maximum negative current,
> > effectively failing silently.
> >
> > Reject -128 to avoid producing the wrong current.
>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
>
> (as agreed to use S8_* limits for now)
>
Applied to the fixes-togreg branch of iio.git.
Note that has a weird base at the moment. I'll probably rebase
and do a pull request very early in next cycle.
We might have to wait a little while to pick up the rest of the
series as a result.
Thanks,
Jonathan
prev parent reply other threads:[~2026-02-05 20:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260204140045.390677-1-o.rempel@pengutronix.de>
2026-02-04 14:00 ` [PATCH v5 01/13] iio: dac: ds4424: reject -128 RAW value Oleksij Rempel
2026-02-04 14:13 ` Andy Shevchenko
2026-02-05 20:14 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260205201407.7d6a6dfa@jic23-huawei \
--to=jic23@kernel.org \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=david@protonic.nl \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=o.rempel@pengutronix.de \
--cc=robh@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox