public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] rust: kbuild: pass `-Zunstable-options` for Rust 1.95.0
@ 2026-02-06 20:45 Miguel Ojeda
  2026-02-06 20:58 ` Miguel Ojeda
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Miguel Ojeda @ 2026-02-06 20:45 UTC (permalink / raw)
  To: Miguel Ojeda, Alex Gaynor, Nathan Chancellor, Nicolas Schier
  Cc: Boqun Feng, Gary Guo, Björn Roy Baron, Benno Lossin,
	Andreas Hindborg, Alice Ryhl, Trevor Gross, Danilo Krummrich,
	rust-for-linux, linux-kbuild, David Wood, Wesley Wiser, stable

Custom target specifications are unstable, but starting with Rust 1.95.0,
`rustc` requires to explicitly pass `-Zunstable-options` to use them [1]:

    error: error loading target specification: custom targets are unstable and require `-Zunstable-options`
      |
      = help: run `rustc --print target-list` for a list of built-in targets

David (Rust compiler team lead), writes:

   "We're destabilising custom targets to allow us to move forward with
    build-std without accidentally exposing functionality that we'd like
    to revisit prior to committing to. I'll start a thread on Zulip to
    discuss with the RfL team how we can come up with an alternative
    for them."

Thus pass it.

Cc: David Wood <david@davidtw.co>
Cc: Wesley Wiser <wwiser@gmail.com>
Cc: stable@vger.kernel.org # Needed in 6.12.y and later (Rust is pinned in older LTSs).
Link: https://github.com/rust-lang/rust/pull/151534 [1]
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
---
 rust/Makefile | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/rust/Makefile b/rust/Makefile
index 4dcc2eff51cb..725158740fc6 100644
--- a/rust/Makefile
+++ b/rust/Makefile
@@ -552,6 +552,8 @@ $(obj)/$(libpin_init_internal_name): private rustc_target_flags = --cfg kernel
 $(obj)/$(libpin_init_internal_name): $(src)/pin-init/internal/src/lib.rs FORCE
 	+$(call if_changed_dep,rustc_procmacro)
 
+# `rustc` requires `-Zunstable-options` to use custom target specifications
+# since Rust 1.95.0 (https://github.com/rust-lang/rust/pull/151534).
 quiet_cmd_rustc_library = $(if $(skip_clippy),RUSTC,$(RUSTC_OR_CLIPPY_QUIET)) L $@
       cmd_rustc_library = \
 	OBJTREE=$(abspath $(objtree)) \
@@ -562,6 +564,7 @@ quiet_cmd_rustc_library = $(if $(skip_clippy),RUSTC,$(RUSTC_OR_CLIPPY_QUIET)) L
 		--crate-type rlib -L$(objtree)/$(obj) \
 		--crate-name $(patsubst %.o,%,$(notdir $@)) $< \
 		--sysroot=/dev/null \
+		-Zunstable-options \
 	$(if $(rustc_objcopy),;$(OBJCOPY) $(rustc_objcopy) $@) \
 	$(cmd_objtool)
 

base-commit: 18f7fcd5e69a04df57b563360b88be72471d6b62
-- 
2.53.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] rust: kbuild: pass `-Zunstable-options` for Rust 1.95.0
  2026-02-06 20:45 [PATCH] rust: kbuild: pass `-Zunstable-options` for Rust 1.95.0 Miguel Ojeda
@ 2026-02-06 20:58 ` Miguel Ojeda
  2026-02-06 21:15 ` Gary Guo
  2026-02-10  8:42 ` Miguel Ojeda
  2 siblings, 0 replies; 4+ messages in thread
From: Miguel Ojeda @ 2026-02-06 20:58 UTC (permalink / raw)
  To: Miguel Ojeda, Gary Guo
  Cc: Alex Gaynor, Nathan Chancellor, Nicolas Schier, Boqun Feng,
	Björn Roy Baron, Benno Lossin, Andreas Hindborg, Alice Ryhl,
	Trevor Gross, Danilo Krummrich, rust-for-linux, linux-kbuild,
	David Wood, Wesley Wiser, stable

On Fri, Feb 6, 2026 at 9:45 PM Miguel Ojeda <ojeda@kernel.org> wrote:
>
> Custom target specifications are unstable, but starting with Rust 1.95.0,
> `rustc` requires to explicitly pass `-Zunstable-options` to use them [1]:
>
>     error: error loading target specification: custom targets are unstable and require `-Zunstable-options`
>       |
>       = help: run `rustc --print target-list` for a list of built-in targets
>
> David (Rust compiler team lead), writes:
>
>    "We're destabilising custom targets to allow us to move forward with
>     build-std without accidentally exposing functionality that we'd like
>     to revisit prior to committing to. I'll start a thread on Zulip to
>     discuss with the RfL team how we can come up with an alternative
>     for them."
>
> Thus pass it.
>
> Cc: David Wood <david@davidtw.co>
> Cc: Wesley Wiser <wwiser@gmail.com>
> Cc: stable@vger.kernel.org # Needed in 6.12.y and later (Rust is pinned in older LTSs).
> Link: https://github.com/rust-lang/rust/pull/151534 [1]
> Signed-off-by: Miguel Ojeda <ojeda@kernel.org>

For reference, this commit is the same one I gave David for the
upstream Rust CI.

Gary would like to have it in `linux-next` for Klint that uses Rust
nightly, so I think I will put it into `rust-fixes` soon-ish to help.

Cheers,
Miguel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] rust: kbuild: pass `-Zunstable-options` for Rust 1.95.0
  2026-02-06 20:45 [PATCH] rust: kbuild: pass `-Zunstable-options` for Rust 1.95.0 Miguel Ojeda
  2026-02-06 20:58 ` Miguel Ojeda
@ 2026-02-06 21:15 ` Gary Guo
  2026-02-10  8:42 ` Miguel Ojeda
  2 siblings, 0 replies; 4+ messages in thread
From: Gary Guo @ 2026-02-06 21:15 UTC (permalink / raw)
  To: Miguel Ojeda, Alex Gaynor, Nathan Chancellor, Nicolas Schier
  Cc: Boqun Feng, Gary Guo, Björn Roy Baron, Benno Lossin,
	Andreas Hindborg, Alice Ryhl, Trevor Gross, Danilo Krummrich,
	rust-for-linux, linux-kbuild, David Wood, Wesley Wiser, stable

On Fri Feb 6, 2026 at 8:45 PM GMT, Miguel Ojeda wrote:
> Custom target specifications are unstable, but starting with Rust 1.95.0,
> `rustc` requires to explicitly pass `-Zunstable-options` to use them [1]:
> 
>     error: error loading target specification: custom targets are unstable and require `-Zunstable-options`
>       |
>       = help: run `rustc --print target-list` for a list of built-in targets
> 
> David (Rust compiler team lead), writes:
> 
>    "We're destabilising custom targets to allow us to move forward with
>     build-std without accidentally exposing functionality that we'd like
>     to revisit prior to committing to. I'll start a thread on Zulip to
>     discuss with the RfL team how we can come up with an alternative
>     for them."
> 
> Thus pass it.
> 
> Cc: David Wood <david@davidtw.co>
> Cc: Wesley Wiser <wwiser@gmail.com>
> Cc: stable@vger.kernel.org # Needed in 6.12.y and later (Rust is pinned in older LTSs).
> Link: https://github.com/rust-lang/rust/pull/151534 [1]
> Signed-off-by: Miguel Ojeda <ojeda@kernel.org>

I can confirm that build will fail on x64 without this patch in latest nightly
and this fixed it.

Reviewed-by: Gary Guo <gary@garyguo.net>
Tested-by: Gary Guo <gary@garyguo.net>

> ---
>  rust/Makefile | 3 +++
>  1 file changed, 3 insertions(+)


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] rust: kbuild: pass `-Zunstable-options` for Rust 1.95.0
  2026-02-06 20:45 [PATCH] rust: kbuild: pass `-Zunstable-options` for Rust 1.95.0 Miguel Ojeda
  2026-02-06 20:58 ` Miguel Ojeda
  2026-02-06 21:15 ` Gary Guo
@ 2026-02-10  8:42 ` Miguel Ojeda
  2 siblings, 0 replies; 4+ messages in thread
From: Miguel Ojeda @ 2026-02-10  8:42 UTC (permalink / raw)
  To: Miguel Ojeda
  Cc: Alex Gaynor, Nathan Chancellor, Nicolas Schier, Boqun Feng,
	Gary Guo, Björn Roy Baron, Benno Lossin, Andreas Hindborg,
	Alice Ryhl, Trevor Gross, Danilo Krummrich, rust-for-linux,
	linux-kbuild, David Wood, Wesley Wiser, stable

On Fri, Feb 6, 2026 at 9:45 PM Miguel Ojeda <ojeda@kernel.org> wrote:
>
> Custom target specifications are unstable, but starting with Rust 1.95.0,
> `rustc` requires to explicitly pass `-Zunstable-options` to use them [1]:
>
>     error: error loading target specification: custom targets are unstable and require `-Zunstable-options`
>       |
>       = help: run `rustc --print target-list` for a list of built-in targets
>
> David (Rust compiler team lead), writes:
>
>    "We're destabilising custom targets to allow us to move forward with
>     build-std without accidentally exposing functionality that we'd like
>     to revisit prior to committing to. I'll start a thread on Zulip to
>     discuss with the RfL team how we can come up with an alternative
>     for them."
>
> Thus pass it.
>
> Cc: David Wood <david@davidtw.co>
> Cc: Wesley Wiser <wwiser@gmail.com>
> Cc: stable@vger.kernel.org # Needed in 6.12.y and later (Rust is pinned in older LTSs).
> Link: https://github.com/rust-lang/rust/pull/151534 [1]
> Signed-off-by: Miguel Ojeda <ojeda@kernel.org>

Applied to `rust-fixes` -- thanks!

This is so that Gary gets it soon in linux-next for Klint -- I may or
may not need to rebase this one, though.

Cheers,
Miguel

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-02-10  8:42 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-06 20:45 [PATCH] rust: kbuild: pass `-Zunstable-options` for Rust 1.95.0 Miguel Ojeda
2026-02-06 20:58 ` Miguel Ojeda
2026-02-06 21:15 ` Gary Guo
2026-02-10  8:42 ` Miguel Ojeda

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox