From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5232D3D544 for ; Sat, 7 Feb 2026 19:46:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770493609; cv=none; b=Hj09zUZ/eHUc5vP+2Lc3L8JdYhEfTgpTy4BZ4AOnFDnMNsoILSVdZJoynD9wTXfISDi+mD76S+hQdT4TFpXJttPRym3eWE7FjtpUfgU7LhCsOaq4btAou33Kjk+AgZsZD7VL8jslHiVRujw9jWFjiwU05CRetbxSAoQOrosH0AI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770493609; c=relaxed/simple; bh=VBjULUzn120ur3IW6k8F7cC+diB1+mjC5RCg/BgAGLE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fx+YwBZTt9KRvCSYSV1CIYk/Qvu6cNehgxTS/1c7fm/IuDZFo10iCKxm4Z7mz7nZr0q8lV+R4yUyxhI/NBmLzqBXagPqdBz+6TFO2j13MbJd69BE1KmreyFP6v+msFmcZPltIqTY4YaAl0fDvz2PtqAyVDuMr+8xrKqs+0x3p9Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ickEY0pc; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ickEY0pc" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 34090C116D0; Sat, 7 Feb 2026 19:46:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1770493608; bh=VBjULUzn120ur3IW6k8F7cC+diB1+mjC5RCg/BgAGLE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ickEY0pcBaGZljuy7Va/ofNFmTGJ/RviYzW51bCfTyYe42fg1gySpFfOlQuiRFT3a Q/ECW0VwEebREawPb+Sg1Gy8xeuVNdvDB+sqkxQGVZykPXuK0z7LuQFAfSLmnTqf4Z 5oo5Q/QOWrleD3PF3sjgrdzD56qwQQSSGXR0j2fmGC5rekUx2bIVE63lVBbau0uGcu CIrFf5tUYnecLIWaRkTCOL5qXZdSNN6PqIy9aHsJwdPgVrjhXqlbW6wqw0KTDP4XB5 D7NLllNCyjmZbZB9cs0LCtGcgP96VyEsLQuzTrInNAy/FdA1qB4Om4zIIUQWEs87V9 HPeRtYhsZPPMg== From: Sasha Levin To: stable@vger.kernel.org Cc: Max Yuan , Jordan Rhee , Joshua Washington , Matt Olson , Harshitha Ramamurthy , Jacob Keller , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.10.y] gve: Correct ethtool rx_dropped calculation Date: Sat, 7 Feb 2026 14:46:45 -0500 Message-ID: <20260207194645.533741-1-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <2026020704-caring-doornail-1175@gregkh> References: <2026020704-caring-doornail-1175@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Max Yuan [ Upstream commit c7db85d579a1dccb624235534508c75fbf2dfe46 ] The gve driver's "rx_dropped" statistic, exposed via `ethtool -S`, incorrectly includes `rx_buf_alloc_fail` counts. These failures represent an inability to allocate receive buffers, not true packet drops where a received packet is discarded. This misrepresentation can lead to inaccurate diagnostics. This patch rectifies the ethtool "rx_dropped" calculation. It removes `rx_buf_alloc_fail` from the total and adds `xdp_tx_errors` and `xdp_redirect_errors`, which represent legitimate packet drops within the XDP path. Cc: stable@vger.kernel.org Fixes: 433e274b8f7b ("gve: Add stats for gve.") Signed-off-by: Max Yuan Reviewed-by: Jordan Rhee Reviewed-by: Joshua Washington Reviewed-by: Matt Olson Signed-off-by: Harshitha Ramamurthy Reviewed-by: Jacob Keller Link: https://patch.msgid.link/20260202193925.3106272-3-hramamurthy@google.com Signed-off-by: Jakub Kicinski [ removed rx_buf_alloc_fail from rx_dropped calculation ] Signed-off-by: Sasha Levin --- drivers/net/ethernet/google/gve/gve_ethtool.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/ethernet/google/gve/gve_ethtool.c b/drivers/net/ethernet/google/gve/gve_ethtool.c index cbfd007449351..2a52cce7838e0 100644 --- a/drivers/net/ethernet/google/gve/gve_ethtool.c +++ b/drivers/net/ethernet/google/gve/gve_ethtool.c @@ -209,8 +209,7 @@ gve_get_ethtool_stats(struct net_device *netdev, data[i++] = rx_bytes; data[i++] = tx_bytes; /* total rx dropped packets */ - data[i++] = rx_skb_alloc_fail + rx_buf_alloc_fail + - rx_desc_err_dropped_pkt; + data[i++] = rx_skb_alloc_fail + rx_desc_err_dropped_pkt; /* Skip tx_dropped */ i++; @@ -265,7 +264,6 @@ gve_get_ethtool_stats(struct net_device *netdev, data[i++] = tmp_rx_bytes; /* rx dropped packets */ data[i++] = tmp_rx_skb_alloc_fail + - tmp_rx_buf_alloc_fail + tmp_rx_desc_err_dropped_pkt; data[i++] = rx->rx_copybreak_pkt; data[i++] = rx->rx_copied_pkt; -- 2.51.0