From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C5CA3D544 for ; Sat, 7 Feb 2026 19:54:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770494072; cv=none; b=uByM5T11SGv/HQgODMI/2ZpNvJC/62tnQYy8msVla6N/Qg/WdRoejgrDAsUKmfaWLeZZg2Aw2pZ99MpvCEoHZpCi8rFn98i2XyzWed9KjVOoMtU7NFQgbd3gbKQ/4hiwIIhzoWs6ILioFG8aPQyY1vcA4SIJQ67RLv6gIia27DQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770494072; c=relaxed/simple; bh=VYA6ciiwO/aooTuyPHuzkp9A1FnrKfp2o0nUDl9YCGw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BUfgAbWqq2LHmSQngNnmsj/4UTzT+BeyVKJ/SyRDsYQ3/nEMfJftAAxGUsf7Yqjqekq0hGObDNaa4Ft++tltuMaEEhMgijWvKwUWn9/qGR8DogowoRLwVgqI24FAAVf63J2jcf6/wfymAUQQTHTBMHnAgRsGAv4ozcgYTpFCwY8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=NS9XQ9RN; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NS9XQ9RN" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1CFA5C19424; Sat, 7 Feb 2026 19:54:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1770494071; bh=VYA6ciiwO/aooTuyPHuzkp9A1FnrKfp2o0nUDl9YCGw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NS9XQ9RN1EzBJH/m31+fn2bJ2C6hj5l9XxVOAF2rXZHV+iJERr7IvxDKarbXTeb8W jnxJjQnxYlKZSPfKpTCnCfO7PUQyOGQAt0RCb/atYf0XmYzrDXX7o/5EmZXiLndpcZ sF7PZ59du4iBAvMRR9e2omc41SubKEJTJAm7OD2tC79iEkygs62flmP6qttjEtKSR0 IlFAK58X274rVc8RVHkn4ohe5pRrVixAZ37n+T3FGUT4Fqo9lU4soO/c0iguPDdptz /yrzagFYzNxvgnSW0mMD/1vnRd+DOvd596AZPX5pC04usTc4Okd4VBE+LbKnKwWUkj h1Rs/GK5Equ/w== From: Sasha Levin To: stable@vger.kernel.org Cc: Maurizio Lombardi , Keith Busch , Sagi Grimberg , John Meneghini , Christoph Hellwig , Sasha Levin Subject: [PATCH 5.15.y 2/5] nvmet-tcp: fix memory leak when performing a controller reset Date: Sat, 7 Feb 2026 14:54:20 -0500 Message-ID: <20260207195423.535763-2-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260207195423.535763-1-sashal@kernel.org> References: <2026020740-kiln-galvanize-65e4@gregkh> <20260207195423.535763-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Maurizio Lombardi [ Upstream commit af21250bb503a02e705b461886321e394b300524 ] If a reset controller is executed while the initiator is performing some I/O the driver may leak the memory allocated for the commands' iovec. Make sure that nvmet_tcp_uninit_data_in_cmds() releases all the memory. Signed-off-by: Maurizio Lombardi Reviewed-by: Keith Busch Reviewed-by: Sagi Grimberg Reviewed-by: John Meneghini Signed-off-by: Christoph Hellwig Stable-dep-of: 52a0a9854934 ("nvmet-tcp: add bounds checks in nvmet_tcp_build_pdu_iovec") Signed-off-by: Sasha Levin --- drivers/nvme/target/tcp.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/nvme/target/tcp.c b/drivers/nvme/target/tcp.c index 7eb4d06f12294..bf3585652c681 100644 --- a/drivers/nvme/target/tcp.c +++ b/drivers/nvme/target/tcp.c @@ -1473,7 +1473,10 @@ static void nvmet_tcp_uninit_data_in_cmds(struct nvmet_tcp_queue *queue) for (i = 0; i < queue->nr_cmds; i++, cmd++) { if (nvmet_tcp_need_data_in(cmd)) - nvmet_tcp_finish_cmd(cmd); + nvmet_req_uninit(&cmd->req); + + nvmet_tcp_unmap_pdu_iovec(cmd); + nvmet_tcp_free_cmd_buffers(cmd); } if (!queue->nr_cmds && nvmet_tcp_need_data_in(&queue->connect)) { -- 2.51.0