From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5DBE53783C9; Mon, 9 Feb 2026 14:52:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770648762; cv=none; b=r/mTd2cSqIU+l9XHH7YFlHOsHQN7nJPzl8VjPxIdLNvERMMZOTCmi+GDE9uoj9OBsw+FWjH4AzqWIcfM5KX3ooLWz4zDni7Zyt8K0rLow5xTrCkhQmMESnWw4lIJRpmgDP6CVvSO62nLbhL4FpRsumgIr/Ab0EyaQWYcNUkEpug= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770648762; c=relaxed/simple; bh=LUFJjE1gOBOgYT4By1hdLp0hXDM52mW4Wb/Qp7zCVWc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SJK3dY7Xl92K7twXMI/ki+WcqUcQxe3hTbHeCFeM2Vh7sXAy8iYczrxxfCH1ink40guulXyBpZsqdDzShoZL+78/FKgqnAxD1kYMaPtcUMZXD2J3glM4AZFxCe0pnwYR7QzNktB0ZDWhnpn/Dnil1VIa050e2/caQJypYv5qnbE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=GdI0y6Fd; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="GdI0y6Fd" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C58FBC116C6; Mon, 9 Feb 2026 14:52:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1770648762; bh=LUFJjE1gOBOgYT4By1hdLp0hXDM52mW4Wb/Qp7zCVWc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GdI0y6Fdg3ef0CmY0e6l4lPI8nbHnmo+CwgpbV+b1HX5+D852M/chbp5j9p2Bx8vO 5W4wEGWYqy1/VFRnfvr7K4hg1MrXgzUuch0Axlm/X3dvvtYRcU77PF2lLXjUpQ/W7b HRrBZrc8fCY4frs9O8HU8yhdCJ4vExQzECzTePdE= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Simon Horman , Zilin Guan , Kory Maincent , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.10 26/41] net: liquidio: Fix off-by-one error in PF setup_nic_devices() cleanup Date: Mon, 9 Feb 2026 15:24:47 +0100 Message-ID: <20260209142257.755189989@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260209142256.797267956@linuxfoundation.org> References: <20260209142256.797267956@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Zilin Guan [ Upstream commit 8558aef4e8a1a83049ab906d21d391093cfa7e7f ] In setup_nic_devices(), the initialization loop jumps to the label setup_nic_dev_free on failure. The current cleanup loop while(i--) skip the failing index i, causing a memory leak. Fix this by changing the loop to iterate from the current index i down to 0. Also, decrement i in the devlink_alloc failure path to point to the last successfully allocated index. Compile tested only. Issue found using code review. Fixes: f21fb3ed364b ("Add support of Cavium Liquidio ethernet adapters") Suggested-by: Simon Horman Signed-off-by: Zilin Guan Reviewed-by: Kory Maincent Link: https://patch.msgid.link/20260128154440.278369-3-zilin@seu.edu.cn Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/cavium/liquidio/lio_main.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/cavium/liquidio/lio_main.c b/drivers/net/ethernet/cavium/liquidio/lio_main.c index 35e46245f1638..c72dbc7252f96 100644 --- a/drivers/net/ethernet/cavium/liquidio/lio_main.c +++ b/drivers/net/ethernet/cavium/liquidio/lio_main.c @@ -3773,6 +3773,7 @@ static int setup_nic_devices(struct octeon_device *octeon_dev) sizeof(struct lio_devlink_priv)); if (!devlink) { dev_err(&octeon_dev->pci_dev->dev, "devlink alloc failed\n"); + i--; goto setup_nic_dev_free; } @@ -3793,11 +3794,11 @@ static int setup_nic_devices(struct octeon_device *octeon_dev) setup_nic_dev_free: - while (i--) { + do { dev_err(&octeon_dev->pci_dev->dev, "NIC ifidx:%d Setup failed\n", i); liquidio_destroy_nic_device(octeon_dev, i); - } + } while (i--); setup_nic_dev_done: -- 2.51.0