From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99C1137997A; Mon, 9 Feb 2026 14:52:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770648742; cv=none; b=CfNLiVJVLok8msHrcWi68tbaMv+1JFo8U/XLrNblueUWUIpNOnMUwtlIJdDGybRZnE7JPYl5DzsoxqLCSf1VVwJxPsIers1scr7uxHqLUgfeYJ6uUQWxFUhzCyiR8bgOSHapFx6RQ80w8P4vP5/wwGPV8yqYCOk5kM8JtsJh9Oc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770648742; c=relaxed/simple; bh=gHprS7Si8lGX5f6ZUDCrO6WHDym+QXiIFJ9hn4ZDGIk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pKJ61NA3gaKC2++oa6XvwojYp1B6PWU8s1xvAj6N44sRobf//NOmQOAYIUkX1gzWuV0G0E0jvE6iX3NkQ7zJBYQZuMhsXg1lUyW1nHBQE3JDPRLLj1SYmdWY8F8ukBH4WRAtC+3s4HZ+408ZSr2djqy4m2wTl01o7Ygd5q4khVM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Yw5Ubyzp; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Yw5Ubyzp" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B050AC116C6; Mon, 9 Feb 2026 14:52:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1770648742; bh=gHprS7Si8lGX5f6ZUDCrO6WHDym+QXiIFJ9hn4ZDGIk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Yw5Ubyzpn6a4cy+UqmvJwkKy4S/cce4MgsfbMOdL02mysLnas/r/zRHu75xdnRUgx n4ugXWyVCJUe7yx2GPbJHoE2Ng6qp/07/lmm9eyUO6UPaKGPWwYwfx10b41ITiYT/k VNVEAFU9MRd5rA1tkhm5MUDC745EUNqOXv6e9xBQ= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Arnd Bergmann , Guenter Roeck , Sasha Levin Subject: [PATCH 5.10 30/41] hwmon: (occ) Mark occ_init_attribute() as __printf Date: Mon, 9 Feb 2026 15:24:51 +0100 Message-ID: <20260209142257.900464792@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260209142256.797267956@linuxfoundation.org> References: <20260209142256.797267956@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Arnd Bergmann [ Upstream commit 831a2b27914cc880130ffe8fb8d1e65a5324d07f ] This is a printf-style function, which gcc -Werror=suggest-attribute=format correctly points out: drivers/hwmon/occ/common.c: In function 'occ_init_attribute': drivers/hwmon/occ/common.c:761:9: error: function 'occ_init_attribute' might be a candidate for 'gnu_printf' format attribute [-Werror=suggest-attribute=format] Add the attribute to avoid this warning and ensure any incorrect format strings are detected here. Fixes: 744c2fe950e9 ("hwmon: (occ) Rework attribute registration for stack usage") Signed-off-by: Arnd Bergmann Link: https://lore.kernel.org/r/20260203163440.2674340-1-arnd@kernel.org Signed-off-by: Guenter Roeck Signed-off-by: Sasha Levin --- drivers/hwmon/occ/common.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/hwmon/occ/common.c b/drivers/hwmon/occ/common.c index 479ea4ce451a5..1a6c8ebc32e16 100644 --- a/drivers/hwmon/occ/common.c +++ b/drivers/hwmon/occ/common.c @@ -755,6 +755,7 @@ static ssize_t occ_show_extended(struct device *dev, * are dynamically allocated, we cannot use the existing kernel macros which * stringify the name argument. */ +__printf(7, 8) static void occ_init_attribute(struct occ_attribute *attr, int mode, ssize_t (*show)(struct device *dev, struct device_attribute *attr, char *buf), ssize_t (*store)(struct device *dev, struct device_attribute *attr, -- 2.51.0