From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7DA6285073; Mon, 9 Feb 2026 14:48:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770648495; cv=none; b=pu4a68o4dqrwQ4RJNb1t/ILYFv7c9AxVm4AYJ3VDQBnJIib1U1z6TD/nQPnGBGCE3AiCzp4zSkUdmmwUGF23aUOkA26lvkB7c95ULyzXrhPhjtPdc0ffbQzFcYTkS6jIIqpgq6J5Q0kuZmmWOZoXwZYr87K3twcCH6qvnPgY/1c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770648495; c=relaxed/simple; bh=Morcy5PLZDmt/HxdSJBr/saDVeW+k7kj+HREXl/kP0M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KwgNCfTydC7TAswce3fFukxMG61tDgQQPyMcrssspMUE9SW5gFTPKQeY7pjEhVsENCBKdQ7Dluts3r/ow7m+3bQKim1hp1STCEXSX0ba2rRsR1oJcixWwH04aZOl38eR2IEfX/5t/NTlzzGv+iHITnJhn7ideZlm7d1hYawKWv4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Yh0Howrt; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Yh0Howrt" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 02137C116C6; Mon, 9 Feb 2026 14:48:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1770648494; bh=Morcy5PLZDmt/HxdSJBr/saDVeW+k7kj+HREXl/kP0M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Yh0HowrtVW0m9TYM5shKH6a5HivPpfYCQIg4Z9ZXvCUJfYl6KpSdtFvrS7I1qQmE6 YWHFUcpjcnUzi7Yj28FW24nj6YdtJ4OKO3Q3xO7trjWu1A7kWWMoxi48kd9Lydw/OY 3fhcCV6/Fm7Gz4jmPA0cSWZWiWj0gl5+/7mq/WV4= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Maurizio Lombardi , Zhaojuan Guo , Mike Christie , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 6.6 53/86] scsi: target: iscsi: Fix use-after-free in iscsit_dec_conn_usage_count() Date: Mon, 9 Feb 2026 15:24:16 +0100 Message-ID: <20260209142306.689373351@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260209142304.770150175@linuxfoundation.org> References: <20260209142304.770150175@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Maurizio Lombardi [ Upstream commit 9411a89e9e7135cc459178fa77a3f1d6191ae903 ] In iscsit_dec_conn_usage_count(), the function calls complete() while holding the conn->conn_usage_lock. As soon as complete() is invoked, the waiter (such as iscsit_close_connection()) may wake up and proceed to free the iscsit_conn structure. If the waiter frees the memory before the current thread reaches spin_unlock_bh(), it results in a KASAN slab-use-after-free as the function attempts to release a lock within the already-freed connection structure. Fix this by releasing the spinlock before calling complete(). Signed-off-by: Maurizio Lombardi Reported-by: Zhaojuan Guo Reviewed-by: Mike Christie Link: https://patch.msgid.link/20260112165352.138606-2-mlombard@redhat.com Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/target/iscsi/iscsi_target_util.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/target/iscsi/iscsi_target_util.c b/drivers/target/iscsi/iscsi_target_util.c index ee0cf2c74952a..b7fa8eed213bb 100644 --- a/drivers/target/iscsi/iscsi_target_util.c +++ b/drivers/target/iscsi/iscsi_target_util.c @@ -857,8 +857,11 @@ void iscsit_dec_conn_usage_count(struct iscsit_conn *conn) spin_lock_bh(&conn->conn_usage_lock); conn->conn_usage_count--; - if (!conn->conn_usage_count && conn->conn_waiting_on_uc) + if (!conn->conn_usage_count && conn->conn_waiting_on_uc) { + spin_unlock_bh(&conn->conn_usage_lock); complete(&conn->conn_waiting_on_uc_comp); + return; + } spin_unlock_bh(&conn->conn_usage_lock); } -- 2.51.0