From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0FDF83793BF; Mon, 9 Feb 2026 14:41:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770648066; cv=none; b=pOX83ozkVgO4d9i2FD8KL+Kch9H353NtKZH2qRdDOSPAYekPX3QCmRSzj9N4T66OomOpRN6PCEwD6NJCTxorJY/R0QahKPwzEdisumo6F0lKGdPb8Bl/e7Tr/VBVpZiykAG6SBcXZyPp5cQ+BKdkCYmkhNE1KevC4kawD8oTvzM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770648066; c=relaxed/simple; bh=cgiFjmCEoRb1GALlEJw1MSaR4QzciyAsO/QEjKobHfg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=srE0KcsWDIOyFpBVC0f3fgD2WfdJyR0nbl+2kNaKHmRzKI8qB1/otpUp1bk5dRGyVo5bv7N4M3AsV+Cu73iKeOq8UXPgJEnFoiFAaoIdsNpqgn1YGRfWK3uYz2CcCHFbj7srrPdWlGMai3jUTebrjU+XWHofyjShqIsMkIe2w8s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=bKVIs9+/; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="bKVIs9+/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5BDB2C116C6; Mon, 9 Feb 2026 14:41:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1770648065; bh=cgiFjmCEoRb1GALlEJw1MSaR4QzciyAsO/QEjKobHfg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bKVIs9+/FQU8OCyljvAHEp+rdeUVFS/ivBZK4OVHZNL3FSJ/TTIegK5gqQj9/DVNi yD4d+8xwi/m+PNfEwl7VXAEzOLavIp7Hm5VBKk7hkquRhEY9BLYNnHG/GI6LovXe/H aKXy90PoV62P2F11x/EfLd/66oUybfuJyB53MBb0= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Felix Gu , Jon Hunter , Mark Brown , Sasha Levin Subject: [PATCH 6.12 111/113] spi: tegra: Fix a memory leak in tegra_slink_probe() Date: Mon, 9 Feb 2026 15:24:20 +0100 Message-ID: <20260209142314.159100160@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260209142310.204833231@linuxfoundation.org> References: <20260209142310.204833231@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Felix Gu [ Upstream commit 41d9a6795b95d6ea28439ac1e9ce8c95bbca20fc ] In tegra_slink_probe(), when platform_get_irq() fails, it directly returns from the function with an error code, which causes a memory leak. Replace it with a goto label to ensure proper cleanup. Fixes: eb9913b511f1 ("spi: tegra: Fix missing IRQ check in tegra_slink_probe()") Signed-off-by: Felix Gu Reviewed-by: Jon Hunter Link: https://patch.msgid.link/20260202-slink-v1-1-eac50433a6f9@gmail.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- drivers/spi/spi-tegra20-slink.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-tegra20-slink.c b/drivers/spi/spi-tegra20-slink.c index ed1393d159aee..6ea5135915884 100644 --- a/drivers/spi/spi-tegra20-slink.c +++ b/drivers/spi/spi-tegra20-slink.c @@ -1086,8 +1086,10 @@ static int tegra_slink_probe(struct platform_device *pdev) reset_control_deassert(tspi->rst); spi_irq = platform_get_irq(pdev, 0); - if (spi_irq < 0) - return spi_irq; + if (spi_irq < 0) { + ret = spi_irq; + goto exit_pm_put; + } tspi->irq = spi_irq; ret = request_threaded_irq(tspi->irq, tegra_slink_isr, tegra_slink_isr_thread, IRQF_ONESHOT, -- 2.51.0