From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B991B1AF0AF; Mon, 9 Feb 2026 14:34:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770647651; cv=none; b=JKTSYz2UNbJ1S8U+Hldv44EtSYc/9iPqkLgPEEiSMP4YgTSy4+TdIG7qgWzpsqFqNzPU2KFWAdDK0Lk0/dZu5ArAyEAS7i9PDhghnrfviPeL6S20Z4xKWCTu2lPKBXtsWqYjYdyQJzSuk8NYlEIqT0zZDt12zCFgeUoZ3OiVyTQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770647651; c=relaxed/simple; bh=uks4yrUnYFU2qGNWe2UqdyLeghhPIq1Y3q234jE88f0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=STKL3N/bAcMSeTSU37WVSm/Ig5/n7K0orszEp9iuZVsygEiTcMo3oRwmCH3ZIPFUx8yrLJkn3RDCJCeM+7UGCrHJoOi+8udLwEJ2pX8Eg/24ZYk8SRoD1dJdYcDwPf1dAhTxcRD1D338ybh/arUWAJM0H4pUzazu/kA079lPFt0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=vygJpKiM; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="vygJpKiM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 41B73C116C6; Mon, 9 Feb 2026 14:34:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1770647651; bh=uks4yrUnYFU2qGNWe2UqdyLeghhPIq1Y3q234jE88f0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vygJpKiMOyqmjEG1sxunCJeAkj3ghm6xDdXOPeWWD8WbEA+G240bJP5qOwo/zTwMO z5p73oR9OCUg2Hvt9+jBRV41C1qTgWx+BYy8J3H72uLubEvy8uuv5snA4Lhr12IjlS A9IqLiWTv58lK0LK+tMqmwTGTTKl6h/UYJqz9Hzc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Mohammad Heib , Aleksandr Loktionov , Paul Menzel , Tony Nguyen , Sasha Levin , Rinitha S Subject: [PATCH 6.18 130/175] i40e: drop udp_tunnel_get_rx_info() call from i40e_open() Date: Mon, 9 Feb 2026 15:23:23 +0100 Message-ID: <20260209142325.188150212@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260209142320.474120190@linuxfoundation.org> References: <20260209142320.474120190@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Mohammad Heib [ Upstream commit 40857194956dcaf3d2b66d6bd113d844c93bef54 ] The i40e driver calls udp_tunnel_get_rx_info() during i40e_open(). This is redundant because UDP tunnel RX offload state is preserved across device down/up cycles. The udp_tunnel core handles synchronization automatically when required. Furthermore, recent changes in the udp_tunnel infrastructure require querying RX info while holding the udp_tunnel lock. Calling it directly from the ndo_open path violates this requirement, triggering the following lockdep warning: Call Trace: ? __udp_tunnel_nic_assert_locked+0x39/0x40 [udp_tunnel] i40e_open+0x135/0x14f [i40e] __dev_open+0x121/0x2e0 __dev_change_flags+0x227/0x270 dev_change_flags+0x3d/0xb0 devinet_ioctl+0x56f/0x860 sock_do_ioctl+0x7b/0x130 __x64_sys_ioctl+0x91/0xd0 do_syscall_64+0x90/0x170 ... Remove the redundant and unsafe call to udp_tunnel_get_rx_info() from i40e_open() resolve the locking violation. Fixes: 1ead7501094c ("udp_tunnel: remove rtnl_lock dependency") Signed-off-by: Mohammad Heib Reviewed-by: Aleksandr Loktionov Reviewed-by: Paul Menzel Tested-by: Rinitha S (A Contingent worker at Intel) Signed-off-by: Tony Nguyen Signed-off-by: Sasha Levin --- drivers/net/ethernet/intel/i40e/i40e_main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c index 0b1cc0481027a..d3bc3207054f9 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_main.c +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c @@ -9030,7 +9030,6 @@ int i40e_open(struct net_device *netdev) TCP_FLAG_FIN | TCP_FLAG_CWR) >> 16); wr32(&pf->hw, I40E_GLLAN_TSOMSK_L, be32_to_cpu(TCP_FLAG_CWR) >> 16); - udp_tunnel_get_rx_info(netdev); return 0; } -- 2.51.0