Re: [PATCH] ASoC: ops: fix snd_soc_get_volsw for sx controls

[Greg KH <gregkh@linuxfoundation.org>]

On Wed, Feb 11, 2026 at 03:20:32PM +0000, Charles Keepax wrote:
> From: Stefan Binding <sbinding@opensource.cirrus.com>
> 
> [ Upstream commit 095d621141826a2841dae85b52c784c147ea99d3 ]
> 
> SX controls are currently broken, since the clamp introduced in
> commit a0ce874cfaaa ("ASoC: ops: improve snd_soc_get_volsw") does not
> handle SX controls, for example where the min value in the clamp is
> greater than the max value in the clamp.
> 
> Add clamp parameter to prevent clamping in SX controls.
> The nature of SX controls mean that it wraps around 0, with a variable
> number of bits, therefore clamping the value becomes complicated and
> prone to error.
> 
> Fixes 35 kunit tests for soc_ops_test_access.
> 
> Fixes: a0ce874cfaaa ("ASoC: ops: improve snd_soc_get_volsw")
> 
> CC: stable@vger.kernel.org # 6.17
> Co-developed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
> Signed-off-by: Stefan Binding <sbinding@opensource.cirrus.com>
> Tested-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
> Link: https://patch.msgid.link/20251216134938.788625-1-sbinding@opensource.cirrus.com
> Signed-off-by: Mark Brown <broonie@kernel.org>
> Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
> ---
> 
> This is a necessary fix to an earlier change that broke SX ALSA controls
> (see fixes tag), this causes volumes to get set incorrectly on several
> production laptops. It has already been backported to 6.18 stable, however
> seems to have been missed on 6.17. I suspect it was missed due to a
> minor conflict that I have resolved here.

6.17.y is long end-of-life, there is nothing we can do there anymore,
please do not use that kernel tree at this time.  Always look at the
front page of kernel.org for the information about what branches are
still under development, and what ones are not.

thanks,

greg k-h