From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26F6E1684BE; Fri, 13 Feb 2026 13:56:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770990960; cv=none; b=c31Z9kqwBc8pB+CZx3ROuMY1eq2heykgeM/W8T4BWmhorze+VP5qWLp9T1jPWsHkeam5iDm6WZURv88E5z+QZrBmqGrPsswLs6QACcow5d4vQPAYE0E3XMYE0BVLeTL07XaWlUkVuRrvgrcl8iBjTcMVV5nBNPiij6qG9u/r5I4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770990960; c=relaxed/simple; bh=jbHGW6x0D/IRoF1M2XMVSsPqUWTR4Z8prxyqkQfVS9s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=H9Yf8fxvamdEM+lSHirMZ21z3W7bUbu/eBpl50u+NB+8743oC1xTO9ldVqP4lAW4ItZXQX77Q/sLXvu4Ph7W/PcBTCqXd8mT7l9tGDqHLTPRUHkW7y/Qhw/UuIXuYRtYw5/5dl8VSOG4tRZkrxrhIQg+n62kt/kLCwWxUU1RsKI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=RJrPvKts; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="RJrPvKts" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 86510C116C6; Fri, 13 Feb 2026 13:55:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1770990960; bh=jbHGW6x0D/IRoF1M2XMVSsPqUWTR4Z8prxyqkQfVS9s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RJrPvKtsbn9T/8I6ADYWkfVp1ZJfql9+DTSdacatd9/exVoncHIBkSSNWz9KpH5VE CrNfIzX2wWfM6AE2DD2YpCozmgq2qsCc3zwfBSY4mcY6SkdGRcnrMdNLZGkpax3OVt pyEL9qPeaXu12u61HFP9KAkUdpmIIBPY+jgqVGpM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Henrique Carvalho , Namjae Jeon , Steve French Subject: [PATCH 6.12 03/24] smb: server: fix leak of active_num_conn in ksmbd_tcp_new_connection() Date: Fri, 13 Feb 2026 14:48:22 +0100 Message-ID: <20260213134704.854914013@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260213134704.728003077@linuxfoundation.org> References: <20260213134704.728003077@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Henrique Carvalho commit 77ffbcac4e569566d0092d5f22627dfc0896b553 upstream. On kthread_run() failure in ksmbd_tcp_new_connection(), the transport is freed via free_transport(), which does not decrement active_num_conn, leaking this counter. Replace free_transport() with ksmbd_tcp_disconnect(). Fixes: 0d0d4680db22e ("ksmbd: add max connections parameter") Cc: stable@vger.kernel.org Signed-off-by: Henrique Carvalho Acked-by: Namjae Jeon Signed-off-by: Steve French Signed-off-by: Greg Kroah-Hartman --- fs/smb/server/transport_tcp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/fs/smb/server/transport_tcp.c +++ b/fs/smb/server/transport_tcp.c @@ -41,6 +41,7 @@ static const struct ksmbd_transport_ops static void tcp_stop_kthread(struct task_struct *kthread); static struct interface *alloc_iface(char *ifname); +static void ksmbd_tcp_disconnect(struct ksmbd_transport *t); #define KSMBD_TRANS(t) (&(t)->transport) #define TCP_TRANS(t) ((struct tcp_transport *)container_of(t, \ @@ -219,7 +220,7 @@ static int ksmbd_tcp_new_connection(stru if (IS_ERR(handler)) { pr_err("cannot start conn thread\n"); rc = PTR_ERR(handler); - free_transport(t); + ksmbd_tcp_disconnect(KSMBD_TRANS(t)); } return rc;