From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 424FC23645D; Fri, 13 Feb 2026 13:53:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770990808; cv=none; b=Qhk4wlP3FOuKBds87ccIEyYn86xDykEiJloEANalDnbueCP6MTAf9GNC2Y10a+ddhreYlGgRgkczwezzySeANgfaDFwTFpHhD7FNP7o0bxaVnljfrzVOmEOnmfmkVeN2u54CSlLGMm9uczYPYEdMjsPeYpskxd/AFDwKfYCt/Q8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770990808; c=relaxed/simple; bh=M8qv4UwQb+RL3DCcYPMI/t/WD8CHrv8v/BQopYHLyWI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Ga7wmLS9JZk3BxvIXR/NQ+iQuBzS9d4T40qUILTRlGNI9lBKjLMTQfn+xSLqCgnlhmnmD0rLF6drVReC+mvXk0SX+FrSfOyiWEqPm8XxaXxFw4Riabz/Ex3bW9UISI9lV4f0dkpiuPrncJ6GvsIP7jmCCqtYPGwYtMqVaw1/tFg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=OtYxAFtp; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="OtYxAFtp" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A9B99C116C6; Fri, 13 Feb 2026 13:53:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1770990808; bh=M8qv4UwQb+RL3DCcYPMI/t/WD8CHrv8v/BQopYHLyWI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OtYxAFtpGtX0y+YW+CenErcPivsgyWZV/8GECdHjTH31x/5i/y1UhA4MJ5O02kXzV dP6xUqpgJlFlGUMRfwfNd2S+gb0ECxmQZN4rYlVR8ri+5HqsEDvfbbgWzHvBAvTSoA jeU8YeXO/u+m9iHuNiOErXs6qmZTX79HxJi8St1c= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Thorsten Blum , Kanchana P Sridhar , Herbert Xu Subject: [PATCH 6.18 30/49] crypto: iaa - Fix out-of-bounds index in find_empty_iaa_compression_mode Date: Fri, 13 Feb 2026 14:48:14 +0100 Message-ID: <20260213134709.986203326@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260213134708.885500854@linuxfoundation.org> References: <20260213134708.885500854@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Thorsten Blum commit 48329301969f6d21b2ef35f678e40f72b59eac94 upstream. The local variable 'i' is initialized with -EINVAL, but the for loop immediately overwrites it and -EINVAL is never returned. If no empty compression mode can be found, the function would return the out-of-bounds index IAA_COMP_MODES_MAX, which would cause an invalid array access in add_iaa_compression_mode(). Fix both issues by returning either a valid index or -EINVAL. Cc: stable@vger.kernel.org Fixes: b190447e0fa3 ("crypto: iaa - Add compression mode management along with fixed mode") Signed-off-by: Thorsten Blum Acked-by: Kanchana P Sridhar Signed-off-by: Herbert Xu Signed-off-by: Greg Kroah-Hartman --- drivers/crypto/intel/iaa/iaa_crypto_main.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) --- a/drivers/crypto/intel/iaa/iaa_crypto_main.c +++ b/drivers/crypto/intel/iaa/iaa_crypto_main.c @@ -221,15 +221,13 @@ static struct iaa_compression_mode *iaa_ static int find_empty_iaa_compression_mode(void) { - int i = -EINVAL; + int i; - for (i = 0; i < IAA_COMP_MODES_MAX; i++) { - if (iaa_compression_modes[i]) - continue; - break; - } + for (i = 0; i < IAA_COMP_MODES_MAX; i++) + if (!iaa_compression_modes[i]) + return i; - return i; + return -EINVAL; } static struct iaa_compression_mode *find_iaa_compression_mode(const char *name, int *idx)