From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8FCBD24E4A8 for ; Fri, 13 Feb 2026 15:08:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770995338; cv=none; b=AgpqGMjQpYrci5d4ryXOgrU4gBB4sTCsd9hHLN3Be6w+CMKftWoM3eGCy4SqqdJQzZs/8RkkbFZ76n0MESLbuzxTRo8OMJ2KBo7TJcBOqzZqmzpgkoWiR0+TXQJ0JGx0SrsTA8wCz1e3e+1gSJyRuQPCwFh9IjxQbd9iimcLv/Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770995338; c=relaxed/simple; bh=ujyqp6g99bXW2CevXGfStOtn5cavparkr/h6aNCIUaw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Q9AIGtiMaGKkV2hOZCJNPXGSl87s9SetvSgLSxPRIiS+ZTN+krvHf9xg10C7JoS79FhngfalgJtUiHI2x9U6LKKIiLsXqFDzvh6BhWsMbZm6oBZ/+V0vVCwy4m/Qi84VpYyDmKyOes7XAqC9yj92mGsw9o1tB/wNuXUQB9wCqQg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=H6IZjO3v; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="H6IZjO3v" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A1A39C116C6; Fri, 13 Feb 2026 15:08:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1770995338; bh=ujyqp6g99bXW2CevXGfStOtn5cavparkr/h6aNCIUaw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=H6IZjO3vyGA18TlE21IQAqStNbo4NudObXWfyxGEiRZUqm3GBKTCTnlzZBMj3G4Hr VoHi36+1uoZSKZ8zIOZHts6TVx9H91jSTdGOAICAz35YClLD1OoLsHx+bDlVU4K8gt b6mNp/8qq2TV6RkEVl0CTXXvM9OwaLIIDZ/WztAVHS3INpVt1IB86Viw6/nMSOykEB csu5X2WL8w8q1izBAD71xbnHC1TRVVOSAvio4y/QF19mtqSVu/zfr4ElGIjIdy8HtC NHZDbgEfy3uYAIsIOjwhcP7vHXSFp8dHYY2oEjHurUth/gNPqpMYEYP7aEdgyPpXjN uHCiAsvbmLUeg== From: Sasha Levin To: stable@vger.kernel.org Cc: Henrique Carvalho , Namjae Jeon , Steve French , Sasha Levin Subject: [PATCH 5.15.y] smb: server: fix leak of active_num_conn in ksmbd_tcp_new_connection() Date: Fri, 13 Feb 2026 10:08:55 -0500 Message-ID: <20260213150855.3532387-1-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <2026021306-laurel-scariness-bfee@gregkh> References: <2026021306-laurel-scariness-bfee@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Henrique Carvalho [ Upstream commit 77ffbcac4e569566d0092d5f22627dfc0896b553 ] On kthread_run() failure in ksmbd_tcp_new_connection(), the transport is freed via free_transport(), which does not decrement active_num_conn, leaking this counter. Replace free_transport() with ksmbd_tcp_disconnect(). Fixes: 0d0d4680db22e ("ksmbd: add max connections parameter") Cc: stable@vger.kernel.org Signed-off-by: Henrique Carvalho Acked-by: Namjae Jeon Signed-off-by: Steve French Signed-off-by: Sasha Levin --- fs/ksmbd/transport_tcp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/ksmbd/transport_tcp.c b/fs/ksmbd/transport_tcp.c index 176295137045a..7ef201b7ddb57 100644 --- a/fs/ksmbd/transport_tcp.c +++ b/fs/ksmbd/transport_tcp.c @@ -41,6 +41,7 @@ static struct ksmbd_transport_ops ksmbd_tcp_transport_ops; static void tcp_stop_kthread(struct task_struct *kthread); static struct interface *alloc_iface(char *ifname); +static void ksmbd_tcp_disconnect(struct ksmbd_transport *t); #define KSMBD_TRANS(t) (&(t)->transport) #define TCP_TRANS(t) ((struct tcp_transport *)container_of(t, \ @@ -207,7 +208,7 @@ static int ksmbd_tcp_new_connection(struct socket *client_sk) if (IS_ERR(handler)) { pr_err("cannot start conn thread\n"); rc = PTR_ERR(handler); - free_transport(t); + ksmbd_tcp_disconnect(KSMBD_TRANS(t)); } return rc; -- 2.51.0