From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68947364EAF for ; Fri, 13 Feb 2026 16:45:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771001112; cv=none; b=eDizwCs3qk60PxtxnMcQfMIQ9rCtgjTkxL/sd3n5jGaT7mse1NqanlPU7sM1cLh6dgZcd8zIQ5jJ3nTylhTZJLYv1rSZfkzzrK4IRS+7qfJIsQ3FQh0FdJ9Poo3x2j4P1zgdQ+0GLae0R/YY1VYrePXWqtj1mQvDBeTGhibYAC4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771001112; c=relaxed/simple; bh=CsXp1Xnd8x2ZPWC9x+pWIrKaonrdFdYd4rXvpFTeaNE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XxEIJkWEFjf/+GseuvmBaSn2k5h6gvJJMrbw2n0upMpw30CS0gMuv2/czKlzjFZjIXiwmY6wXN4stylItTeV3MrVcK7HZW8SePW+cgpqiQ33VAbXdct9N3DtiIIOWbYpqHcag4Eqamf4ueypD07jaLH/qWD37dXQoA6nvoALn0s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=cbxr+yy/; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="cbxr+yy/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6C7E9C116C6; Fri, 13 Feb 2026 16:45:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1771001112; bh=CsXp1Xnd8x2ZPWC9x+pWIrKaonrdFdYd4rXvpFTeaNE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cbxr+yy/YaCD1SSK9ZJy9M2JoHfdo0vojZcfX+DYUWOCX/Ty1byd52E2T5QhE8am1 IcHJibNYafghcbk6e4Yjz2aClamF9JJrPiZtSDE9gZJASoEr2YKHyOKMaXRrf2rLB1 GRbJnyXoonOKZBVzg3fzdnwZKIFmPkHlW2T+Wp55lhFgulHe0JshlVkaDbCFZ9mDy7 Q1HwWYtazEJTU/pHHSPFvSF3VqMHufOWp70MHkJq3y1R8p4eSyODuwk6ocYN5rInLD xx0pDHPVyMcxCS2tEVNN5b+VSsQrI0S4rA7mq2/eSvVIpg+qVL/q4ZqJqUwCCl0+j0 kv5Jx/l16rFqQ== From: Sasha Levin To: stable@vger.kernel.org Cc: Gui-Dong Han , Ioana Ciornei , "Christophe Leroy (CS GROUP)" , Sasha Levin Subject: [PATCH 6.1.y 2/2] bus: fsl-mc: fix use-after-free in driver_override_show() Date: Fri, 13 Feb 2026 11:45:08 -0500 Message-ID: <20260213164508.3564699-2-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260213164508.3564699-1-sashal@kernel.org> References: <2026021347-showing-tapered-feb3@gregkh> <20260213164508.3564699-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Gui-Dong Han [ Upstream commit 148891e95014b5dc5878acefa57f1940c281c431 ] The driver_override_show() function reads the driver_override string without holding the device_lock. However, driver_override_store() uses driver_set_override(), which modifies and frees the string while holding the device_lock. This can result in a concurrent use-after-free if the string is freed by the store function while being read by the show function. Fix this by holding the device_lock around the read operation. Fixes: 1f86a00c1159 ("bus/fsl-mc: add support for 'driver_override' in the mc-bus") Cc: stable@vger.kernel.org Signed-off-by: Gui-Dong Han Reviewed-by: Ioana Ciornei Link: https://lore.kernel.org/r/20251202174438.12658-1-hanguidong02@gmail.com Signed-off-by: Christophe Leroy (CS GROUP) Signed-off-by: Sasha Levin --- drivers/bus/fsl-mc/fsl-mc-bus.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/bus/fsl-mc/fsl-mc-bus.c b/drivers/bus/fsl-mc/fsl-mc-bus.c index 2dded09f68a6d..8311da43c3d56 100644 --- a/drivers/bus/fsl-mc/fsl-mc-bus.c +++ b/drivers/bus/fsl-mc/fsl-mc-bus.c @@ -201,8 +201,12 @@ static ssize_t driver_override_show(struct device *dev, struct device_attribute *attr, char *buf) { struct fsl_mc_device *mc_dev = to_fsl_mc_device(dev); + ssize_t len; - return sysfs_emit(buf, "%s\n", mc_dev->driver_override); + device_lock(dev); + len = sysfs_emit(buf, "%s\n", mc_dev->driver_override); + device_unlock(dev); + return len; } static DEVICE_ATTR_RW(driver_override); -- 2.51.0