public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: "Igor Klochko (Nokia)" <igor.klochko@nokia.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>,
	"Philippe Belet (Nokia)" <philippe.belet@nokia.com>
Subject: Re: [PATCH] uio: fix uio_unregister_device
Date: Fri, 13 Feb 2026 13:17:15 +0100	[thread overview]
Message-ID: <2026021323-delegator-reusable-4e13@gregkh> (raw)
In-Reply-To: <AM9PR07MB720414361A0BA3BA2CF107208D61A@AM9PR07MB7204.eurprd07.prod.outlook.com>

On Fri, Feb 13, 2026 at 12:09:04PM +0000, Igor Klochko (Nokia) wrote:
> Hi Greg,
> 
> > Nice fix, but what is causing these devices to be created and removed in parallel?  
> It's an outcome of a stress test.
> 
> > Nit, line wrapping at the same column width :)
> > Please use more digits, as the documentation mentions.
> Acknowledged, will resend the patch.
> 
> > So no locking is needed here?  It's only the minor that is getting messed up?
> 
> Only minor. If I look at the history, 0c9ae0b8605078eafc3bea053cc78791e97ba2e2 moved the minor before device unregister.
> 
> However, this breaks a fix done in 
> 8fd0e2a6df262539eaa28b0a2364cca10d1dc662
> uio: free uio id after uio file node is freed
> 
> > And should this be cc: stable?
> 
> 0c9ae0b8605078eafc3bea053cc78791e97ba2e2 is a CVE, so it was applied on LTS kernels, we discovered this on 6.1.
> I thought stable is the right place for these kinds of patches.

I agree, it is, but you need to add "cc: stable@..." to the
signed-off-by area of the patch, as the bot referred to to, if you want
that to happen.

Can you resend this with that added, AND the sha1 fixed up for the
Fixes: tag?

thanks,

greg k-h

      reply	other threads:[~2026-02-13 12:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-13  9:47 [PATCH] uio: fix uio_unregister_device Igor Klochko (Nokia)
2026-02-13 11:50 ` gregkh
2026-02-13 12:09   ` Igor Klochko (Nokia)
2026-02-13 12:17     ` gregkh [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026021323-delegator-reusable-4e13@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=igor.klochko@nokia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=philippe.belet@nokia.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox