From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D980B3EBF2C for ; Sat, 14 Feb 2026 01:02:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771030959; cv=none; b=eEwwca+Frt/afT0GkEcoARElUeGvjGiPa9oHkM/Yx0hxU0Z1ys91m/Mu1CywcYSDy57KoFd6iBTU+A5fQXo8i6jsSdv5N6ubEp24Fg5AimulB8tl4y8x9JsjCokeCFjKimTi7wFH9/RypxyfwBVwv5D+yneUmUdJfLgKzndMkHs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771030959; c=relaxed/simple; bh=vW2WilTv8rqnu27DqG6JPB5q4Xqd69d5N1L7ZALohHw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RBwVhhHn1yE/7lBBsZu5IjZ90tmPB6lm6R/pYp+v4k7Uko80vtLAQFlHzQ9LTSH/OVEa3BOV/1pdTnbI4++gZ8UrZ6oL5wqYzCUhZtWFPfTkrT9Bo3AM7eJPrBdL1J92F4l5OVzi7Tt3g/rL7oeA4anlRXQJKhbrKncOicSeWok= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=V3E1+FQK; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="V3E1+FQK" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2E73AC19424; Sat, 14 Feb 2026 01:02:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1771030959; bh=vW2WilTv8rqnu27DqG6JPB5q4Xqd69d5N1L7ZALohHw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=V3E1+FQK1z6kWabE+Ad/1VFAm4sIf83RywPAaKkOJc922oFd7C/n8jsvdt0KZbaOV 0QYFAiOzzKKa6loJVDOA80EbnNr+iC0HEy5h6Bq31q6zDo0GjQQRmdLwDzNssYVTg+ cGQV0wWLFPPRtWezJ4gvGzs/1C+Bhekgl7fm4HU6a0Jh+enUNClA1R7wJi6t9O23nW w8j4boq+pvYiwr63Hyl4BwrV949evCnrmc8zJi5tO3xPNlyWlINW09xEKcaHtbMnrg Dx0yK8r0nUQCM7NzVnjOdTP9to09XXUd5qiaeG9iKsKcYkycHzK9PoO7weuoWDOvcn sOJ1HWy0FNIAA== From: Sasha Levin To: stable@vger.kernel.org Cc: Gui-Dong Han , Ioana Ciornei , "Christophe Leroy (CS GROUP)" , Sasha Levin Subject: [PATCH 5.10.y 2/2] bus: fsl-mc: fix use-after-free in driver_override_show() Date: Fri, 13 Feb 2026 20:02:36 -0500 Message-ID: <20260214010236.3700986-2-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260214010236.3700986-1-sashal@kernel.org> References: <2026021348-eldest-semantic-7287@gregkh> <20260214010236.3700986-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Gui-Dong Han [ Upstream commit 148891e95014b5dc5878acefa57f1940c281c431 ] The driver_override_show() function reads the driver_override string without holding the device_lock. However, driver_override_store() uses driver_set_override(), which modifies and frees the string while holding the device_lock. This can result in a concurrent use-after-free if the string is freed by the store function while being read by the show function. Fix this by holding the device_lock around the read operation. Fixes: 1f86a00c1159 ("bus/fsl-mc: add support for 'driver_override' in the mc-bus") Cc: stable@vger.kernel.org Signed-off-by: Gui-Dong Han Reviewed-by: Ioana Ciornei Link: https://lore.kernel.org/r/20251202174438.12658-1-hanguidong02@gmail.com Signed-off-by: Christophe Leroy (CS GROUP) Signed-off-by: Sasha Levin --- drivers/bus/fsl-mc/fsl-mc-bus.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/bus/fsl-mc/fsl-mc-bus.c b/drivers/bus/fsl-mc/fsl-mc-bus.c index 7b0c58f31acf2..48e5990394a51 100644 --- a/drivers/bus/fsl-mc/fsl-mc-bus.c +++ b/drivers/bus/fsl-mc/fsl-mc-bus.c @@ -194,8 +194,12 @@ static ssize_t driver_override_show(struct device *dev, struct device_attribute *attr, char *buf) { struct fsl_mc_device *mc_dev = to_fsl_mc_device(dev); + ssize_t len; - return sysfs_emit(buf, "%s\n", mc_dev->driver_override); + device_lock(dev); + len = sysfs_emit(buf, "%s\n", mc_dev->driver_override); + device_unlock(dev); + return len; } static DEVICE_ATTR_RW(driver_override); -- 2.51.0