Re: [PATCH 6.6.y] gve: defer interrupt enabling until NAPI registration

[Greg KH <gregkh@linuxfoundation.org>]

On Fri, Feb 13, 2026 at 01:17:02PM -0800, Joshua Washington wrote:
> From: Ankit Garg <nktgrg@google.com>
> 
> [ Upstream commit 3d970eda003441f66551a91fda16478ac0711617 ]
> 
> Currently, interrupts are automatically enabled immediately upon
> request. This allows interrupt to fire before the associated NAPI
> context is fully initialized and cause failures like below:
> 
> [    0.946369] Call Trace:
> [    0.946369]  <IRQ>
> [    0.946369]  __napi_poll+0x2a/0x1e0
> [    0.946369]  net_rx_action+0x2f9/0x3f0
> [    0.946369]  handle_softirqs+0xd6/0x2c0
> [    0.946369]  ? handle_edge_irq+0xc1/0x1b0
> [    0.946369]  __irq_exit_rcu+0xc3/0xe0
> [    0.946369]  common_interrupt+0x81/0xa0
> [    0.946369]  </IRQ>
> [    0.946369]  <TASK>
> [    0.946369]  asm_common_interrupt+0x22/0x40
> [    0.946369] RIP: 0010:pv_native_safe_halt+0xb/0x10
> 
> Use the `IRQF_NO_AUTOEN` flag when requesting interrupts to prevent auto
> enablement and explicitly enable the interrupt in NAPI initialization
> path (and disable it during NAPI teardown).
> 
> This ensures that interrupt lifecycle is strictly coupled with
> readiness of NAPI context.
> 
> Cc: stable@vger.kernel.org
> Fixes: 893ce44df565 ("gve: Add basic driver framework for Compute Engine Virtual NIC")

Why did you change the Fixes line here?  Did the original commit lie
about it?  If so, that's fine, but this is really going to cause tools a
mess to keep track of...


> Signed-off-by: Ankit Garg <nktgrg@google.com>
> Reviewed-by: Jordan Rhee <jordanrhee@google.com>
> Signed-off-by: Harshitha Ramamurthy <hramamurthy@google.com>
> Link: https://patch.msgid.link/20251219102945.2193617-1-hramamurthy@google.com
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
> Signed-off-by: Joshua Washington <joshwash@google.com>
> ---
> 
> Note: This patch has been modified form the original to re-introduce the
> irq member to struct gve_notify_block, which was introuduced in commit
> 9a5e0776d11f ("gve: Avoid rescheduling napi if on wrong cpu").

Can you put this in a "comment" above your signed off like:

Signed-off-by: Paolo Abeni <pabeni@redhat.com>
[ modified to re-introduce the irq member to struct gve_notify_block,
  which was introuduced in commit 9a5e0776d11f ("gve: Avoid rescheduling
  napi if on wrong cpu"). ]
Signed-off-by: Joshua Washington <joshwash@google.com>

Also, it's "from", not "form" :)

Same for all of the other backports here, can you fix them all up
please and send a v2?

thanks,

greg k-h