From: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>
To: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
intel-xe@lists.freedesktop.org
Cc: contact@emersion.fr, alex.hung@amd.com, harry.wentland@amd.com,
daniels@collabora.com, mwen@igalia.com,
sebastian.wick@redhat.com, uma.shankar@intel.com,
ville.syrjala@linux.intel.com, maarten.lankhorst@linux.intel.com,
jani.nikula@intel.com, louis.chauvet@bootlin.com,
stable@vger.kernel.org, chaitanya.kumar.borah@intel.com
Subject: [PATCH 1/2] drm/colorop: Preserve bypass value in duplicate_state()
Date: Wed, 18 Feb 2026 12:27:12 +0530 [thread overview]
Message-ID: <20260218065713.326417-2-chaitanya.kumar.borah@intel.com> (raw)
In-Reply-To: <20260218065713.326417-1-chaitanya.kumar.borah@intel.com>
__drm_atomic_helper_colorop_duplicate_state() unconditionally
sets state->bypass = true after copying the existing state.
This override causes the new atomic state to no longer reflect
the currently committed hardware state. Since the bypass property
directly controls whether the colorop is active in hardware,
resetting it to true can inadvertently disable an active colorop
during a subsequent commit, particularly for internal driver commits
where userspace does not touch the property.
Drop the unconditional assignment and preserve the duplicated
bypass value.
Fixes: 8c5ea1745f4c ("drm/colorop: Add BYPASS property")
Cc: <stable@vger.kernel.org> #v6.19+
Signed-off-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>
---
drivers/gpu/drm/drm_colorop.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_colorop.c b/drivers/gpu/drm/drm_colorop.c
index aa19de769eb2..5037efcc3497 100644
--- a/drivers/gpu/drm/drm_colorop.c
+++ b/drivers/gpu/drm/drm_colorop.c
@@ -466,8 +466,6 @@ static void __drm_atomic_helper_colorop_duplicate_state(struct drm_colorop *colo
if (state->data)
drm_property_blob_get(state->data);
-
- state->bypass = true;
}
struct drm_colorop_state *
--
2.25.1
next prev parent reply other threads:[~2026-02-18 7:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-18 6:57 [PATCH 0/2] drm/colorop: Keep colorop state consistent across atomic commits Chaitanya Kumar Borah
2026-02-18 6:57 ` Chaitanya Kumar Borah [this message]
2026-02-23 20:33 ` [PATCH 1/2] drm/colorop: Preserve bypass value in duplicate_state() Shankar, Uma
2026-02-18 6:57 ` [PATCH 2/2] drm/atomic: Add affected colorops with affected planes Chaitanya Kumar Borah
2026-02-23 20:37 ` Shankar, Uma
2026-03-10 21:07 ` Borah, Chaitanya Kumar
2026-02-23 21:14 ` [PATCH 0/2] drm/colorop: Keep colorop state consistent across atomic commits Harry Wentland
2026-02-24 8:59 ` Shankar, Uma
2026-02-26 5:59 ` Borah, Chaitanya Kumar
2026-03-10 21:00 ` Borah, Chaitanya Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260218065713.326417-2-chaitanya.kumar.borah@intel.com \
--to=chaitanya.kumar.borah@intel.com \
--cc=alex.hung@amd.com \
--cc=contact@emersion.fr \
--cc=daniels@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=harry.wentland@amd.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=louis.chauvet@bootlin.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mwen@igalia.com \
--cc=sebastian.wick@redhat.com \
--cc=stable@vger.kernel.org \
--cc=uma.shankar@intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox