From: Koen Koning <koen.koning@linux.intel.com>
To: dri-devel@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org,
"Joel Fernandes" <joelagnelf@nvidia.com>,
"Matthew Auld" <matthew.auld@intel.com>,
"Danilo Krummrich" <dakr@kernel.org>,
"Koen Koning" <koen.koning@linux.intel.com>,
"Chunming Zhou" <david1.zhou@amd.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Lucas Stach" <l.stach@pengutronix.de>,
"Matthew Brost" <matthew.brost@intel.com>,
"Philipp Stanner" <phasta@kernel.org>,
"Christian König" <ckoenig.leichtzumerken@gmail.com>,
stable@vger.kernel.org
Subject: [PATCH v3 2/3] drm/sched: fix module_init() usage
Date: Thu, 19 Feb 2026 22:38:57 +0100 [thread overview]
Message-ID: <20260219213858.370675-3-koen.koning@linux.intel.com> (raw)
In-Reply-To: <20260219213858.370675-1-koen.koning@linux.intel.com>
Use subsys_initcall() instead of module_init() (which compiles to
device_initcall() for built-ins) for sched_fence, so its initialization
code always runs before any (built-in) drivers.
This happened to work correctly so far due to the order of linking in
the Makefiles, but this should not be relied upon.
Fixes: 4983e48c85392 ("drm/sched: move fence slab handling to module init/exit")
Cc: Chunming Zhou <david1.zhou@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: Lucas Stach <l.stach@pengutronix.de>
Cc: Matthew Brost <matthew.brost@intel.com>
Cc: Danilo Krummrich <dakr@kernel.org>
Cc: Philipp Stanner <phasta@kernel.org>
Cc: "Christian König" <ckoenig.leichtzumerken@gmail.com>
Cc: Matthew Auld <matthew.auld@intel.com>
Cc: stable@vger.kernel.org
Signed-off-by: Koen Koning <koen.koning@linux.intel.com>
---
drivers/gpu/drm/scheduler/sched_fence.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/scheduler/sched_fence.c b/drivers/gpu/drm/scheduler/sched_fence.c
index 9391d6f0dc01..d10c1163719f 100644
--- a/drivers/gpu/drm/scheduler/sched_fence.c
+++ b/drivers/gpu/drm/scheduler/sched_fence.c
@@ -235,7 +235,7 @@ void drm_sched_fence_init(struct drm_sched_fence *fence,
&fence->lock, entity->fence_context + 1, seq);
}
-module_init(drm_sched_fence_slab_init);
+subsys_initcall(drm_sched_fence_slab_init);
module_exit(drm_sched_fence_slab_fini);
MODULE_DESCRIPTION("DRM GPU scheduler");
--
2.48.1
next prev parent reply other threads:[~2026-02-19 21:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260216111902.110286-1-koen.koning@linux.intel.com>
[not found] ` <20260219213858.370675-1-koen.koning@linux.intel.com>
2026-02-19 21:38 ` [PATCH v3 1/3] gpu/buddy: fix module_init() usage Koen Koning
2026-02-20 6:06 ` Greg KH
2026-02-20 10:17 ` Danilo Krummrich
2026-02-20 13:55 ` Joel Fernandes
2026-02-21 5:44 ` Greg KH
2026-02-23 0:49 ` Joel Fernandes
2026-02-23 11:17 ` Koen Koning
2026-02-23 11:20 ` Danilo Krummrich
2026-02-23 13:42 ` Joel Fernandes
2026-02-23 22:31 ` Danilo Krummrich
2026-02-24 3:41 ` David Airlie
2026-02-19 21:38 ` Koen Koning [this message]
2026-02-20 6:06 ` [PATCH v3 2/3] drm/sched: " Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260219213858.370675-3-koen.koning@linux.intel.com \
--to=koen.koning@linux.intel.com \
--cc=alexander.deucher@amd.com \
--cc=ckoenig.leichtzumerken@gmail.com \
--cc=dakr@kernel.org \
--cc=david1.zhou@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=joelagnelf@nvidia.com \
--cc=l.stach@pengutronix.de \
--cc=matthew.auld@intel.com \
--cc=matthew.brost@intel.com \
--cc=phasta@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox