From: Greg KH <gregkh@linuxfoundation.org>
To: Filipe Manana <fdmanana@kernel.org>
Cc: Mark Harmstone <mark@harmstone.com>,
linux-btrfs@vger.kernel.org, johannes.thumshirn@wdc.com,
stable@vger.kernel.org
Subject: Re: [PATCH] btrfs: fix chunk map leak in btrfs_map_block() after btrfs_chunk_map_num_copies()
Date: Fri, 20 Feb 2026 14:20:53 +0100 [thread overview]
Message-ID: <2026022052-aqueduct-gallows-a487@gregkh> (raw)
In-Reply-To: <CAL3q7H6RnMw=GLAuv20u0e8azr5Tyr_wXFKKjUEgvp3iFAak_g@mail.gmail.com>
On Fri, Feb 20, 2026 at 01:07:27PM +0000, Filipe Manana wrote:
> On Fri, Feb 20, 2026 at 1:02 PM Mark Harmstone <mark@harmstone.com> wrote:
> >
> > Fix a chunk map leak in btrfs_map_block(): if we return early with -EINVAL,
> > we're not freeing the chunk map that we've just looked up.
> >
> > Signed-off-by: Mark Harmstone <mark@harmstone.com>
> > Cc: stable@vger.kernel.org
> > Fixes: 0ae653fbec2b ("btrfs: reduce chunk_map lookups in btrfs_map_block()")
>
> Reviewed-by: Filipe Manana <fdmanana@suse.com>
>
> Side note: if there's a Fixes tag, we don't need a CC stable tag
> anymore nowadays.
Not true at all, please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
You HAVE to have a cc: stable if you know you want it to be added to a
stable tree. If you do not do that, you are at the mercy of "when Greg
and Sasha get bored and attempt to pick up things that maintainers
forgot about".
thanks,
greg k-h
prev parent reply other threads:[~2026-02-20 13:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-20 13:01 [PATCH] btrfs: fix chunk map leak in btrfs_map_block() after btrfs_chunk_map_num_copies() Mark Harmstone
2026-02-20 13:07 ` Filipe Manana
2026-02-20 13:20 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026022052-aqueduct-gallows-a487@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=fdmanana@kernel.org \
--cc=johannes.thumshirn@wdc.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=mark@harmstone.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox