From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 31C4D331223 for ; Mon, 23 Feb 2026 17:23:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771867385; cv=none; b=JTfIe6QNKomnncdiFQxSOl1UCC3Bv5R7NEZrw5qXyju58mLDRdLEnjDrcZnH8Zg0WtJICYiuIfKv4d7oa7Io9ZcyB3d+Ah4Phw4Wuj/pN3S++tEHt/Nmckfa3XhvoaM/NQQq2eAxhIK6m6UNfDMcsaTO/oDClTWUVy38SHecs8w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771867385; c=relaxed/simple; bh=6twDK4PtKIbbjQ8V+RHrxcAhdc5TjEARtkXHmsl19pg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=f/eApPGWuvEFa2VLUzOs6//a22ftUr95UD/HXCul5DY933248wpadJk46lpEisM2mgAgpk6oOHO0qRf7n/UIf/FVVuuge6un7RRNOSavOwd9dKLlJ5UKngseCW5o1Xo9JXEeJ9BGrRGS1FVPEU8x/11ydLHQeNABor0nBIXoykk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=cloudlinux.com; spf=pass smtp.mailfrom=cloudlinux.com; dkim=pass (2048-bit key) header.d=cloudlinux.com header.i=@cloudlinux.com header.b=S004EusB; arc=none smtp.client-ip=209.85.210.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=cloudlinux.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cloudlinux.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cloudlinux.com header.i=@cloudlinux.com header.b="S004EusB" Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-8249aca0affso2384288b3a.3 for ; Mon, 23 Feb 2026 09:23:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudlinux.com; s=google; t=1771867383; x=1772472183; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=orzynsfZe+CfKZLFbnSw+MMwoOIvE1/9JZb6UfpnxUs=; b=S004EusBfVrBMccedzLcscITVTMjeqFmWxibWS6lkAhYSwJxWpLSewwyEQi1gIEft+ QKFFy7LNi8yQdVrG8eXweZkNFiyTq0B4wJehzjid9nNCTSXy/7MNytxIoPueIU6+5BeK dSY5khNpUSLDZtMxs2r0IehcVAdOo6uADTXtj2TZlvJG4ktRsVZoWiqaRaj5IRlTPPEq jg/zXXpFLw8xqNOuV2W6I5ngiJ5st5BdzyQWXopWMNCbaD5xpZdZdnbOWVbGx1R8gDvr T7FmAQoymbJSQ21tzV3XcibHw4qzK6VOKR7VJMpcHG0Q6YF0QyLgogjGEfAc/+mmXAsF 62ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771867383; x=1772472183; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=orzynsfZe+CfKZLFbnSw+MMwoOIvE1/9JZb6UfpnxUs=; b=tpz2v+7MN5/LE8t4DqgjDb7ph3fLn8RDtFhoFwazGt3+OqPhuOpU5M0OQUpXOHD3CN T8ZbOGod/DCao9W5h1mpv4JtN9QIhdCLBMCqrT1LvZcaXCb4MlNVh0tpslq/kQbWyD3I yZT6jepaxK18fkoChwbyNYZM8EbN1cmJnDutt+SPTrpbjfS0Gi3s9FVZZ4g7GyDKSJwt 8AYSTDMr8/hW6Fflw67IpPM0FOW++Ka0F5S9dXAIo3lpFqieUAROsA7nRb1wv9YoTewu iFChjmxs6pXVvKwDFP+3it1fRFKQiOdmvy7ap+FRMmKZbmHhWij0i2Gouk+FXhsSS2um DDzQ== X-Gm-Message-State: AOJu0YyoLAmRuNdxae/MddXmsTBdUlIxTL13LATxiXpqod6rMGDKTWHt DSBqVKtIzN0K/rE4C6Kf8T1INGGkMTnDYXeSKIGrKEJ61ZO/Dh5ILgoZBJkxLXlaOEA8tldNJNU 9nzJY X-Gm-Gg: AZuq6aJtoCKQlnHLz9ZDCUWdZ4La6RYxYL8Qg3gQITBCeW7Ow3d9737AuUgj3mhZLdk mI84nGzdIHq0IFwuqKHymATGZlKkZOHwJZ7NjCMG9kiX7KwrGfxdvjYJziXzNnq0eDkIrTy1TK8 AUNie3YtT3qhvLisT6zEOdkQ7KSNgADvXB+aZZHiRNT16Oc8nGHZLhmFuX0NDdFeH9q7CvVOVVP 1xcD2fVZpiEzcJM8t8UrgXZLKxaoZVUMhQyKSQ/ODuO68SKZ408C1/KxRdv/Ogdrrujgyd+pC2E mJJcAIrAzDtOuA76wrxhDNWjRohLwHxzMBw7KYBpE+3baLCgUesKNz+o/NUncETvNwjRGnDE1gy Uu9TAo9NK523wxerCejdjWkntM+bvZhl3QxfX6rLX8pg43D6zkf6CpqyRB8egpO6HGXMarANNRX 5YA/5YmXGB6WtX7+oS6P1BMveL/IL5i9k= X-Received: by 2002:a05:6a21:1519:b0:38d:ee68:2c60 with SMTP id adf61e73a8af0-39545f8b3c4mr8941153637.52.1771867383087; Mon, 23 Feb 2026 09:23:03 -0800 (PST) Received: from outpost.localdomain ([110.44.9.85]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c70b7269771sm7942918a12.30.2026.02.23.09.22.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Feb 2026 09:23:02 -0800 (PST) From: Jaskaran Singh To: stable@vger.kernel.org, james.smart@broadcom.com, kbusch@kernel.org, axboe@fb.com, hch@lst.de, sagi@grimberg.me Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, Jaskaran Singh , Marco Patalano , Justin Tee , "Ewan D . Milne" Subject: [PATCH 5.10.y 2/2] nvme: nvme-fc: Ensure ->ioerr_work is cancelled in nvme_fc_delete_ctrl() Date: Mon, 23 Feb 2026 22:52:41 +0530 Message-Id: <20260223172241.291649-3-jsingh@cloudlinux.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260223172241.291649-1-jsingh@cloudlinux.com> References: <20260223172241.291649-1-jsingh@cloudlinux.com> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit commit 0a2c5495b6d1ecb0fa18ef6631450f391a888256 upstream. nvme_fc_delete_assocation() waits for pending I/O to complete before returning, and an error can cause ->ioerr_work to be queued after cancel_work_sync() had been called. Move the call to cancel_work_sync() to be after nvme_fc_delete_association() to ensure ->ioerr_work is not running when the nvme_fc_ctrl object is freed. Otherwise the following can occur: [ 1135.911754] list_del corruption, ff2d24c8093f31f8->next is NULL [ 1135.917705] ------------[ cut here ]------------ [ 1135.922336] kernel BUG at lib/list_debug.c:52! [ 1135.926784] Oops: invalid opcode: 0000 [#1] SMP NOPTI [ 1135.931851] CPU: 48 UID: 0 PID: 726 Comm: kworker/u449:23 Kdump: loaded Not tainted 6.12.0 #1 PREEMPT(voluntary) [ 1135.943490] Hardware name: Dell Inc. PowerEdge R660/0HGTK9, BIOS 2.5.4 01/16/2025 [ 1135.950969] Workqueue: 0x0 (nvme-wq) [ 1135.954673] RIP: 0010:__list_del_entry_valid_or_report.cold+0xf/0x6f [ 1135.961041] Code: c7 c7 98 68 72 94 e8 26 45 fe ff 0f 0b 48 c7 c7 70 68 72 94 e8 18 45 fe ff 0f 0b 48 89 fe 48 c7 c7 80 69 72 94 e8 07 45 fe ff <0f> 0b 48 89 d1 48 c7 c7 a0 6a 72 94 48 89 c2 e8 f3 44 fe ff 0f 0b [ 1135.979788] RSP: 0018:ff579b19482d3e50 EFLAGS: 00010046 [ 1135.985015] RAX: 0000000000000033 RBX: ff2d24c8093f31f0 RCX: 0000000000000000 [ 1135.992148] RDX: 0000000000000000 RSI: ff2d24d6bfa1d0c0 RDI: ff2d24d6bfa1d0c0 [ 1135.999278] RBP: ff2d24c8093f31f8 R08: 0000000000000000 R09: ffffffff951e2b08 [ 1136.006413] R10: ffffffff95122ac8 R11: 0000000000000003 R12: ff2d24c78697c100 [ 1136.013546] R13: fffffffffffffff8 R14: 0000000000000000 R15: ff2d24c78697c0c0 [ 1136.020677] FS: 0000000000000000(0000) GS:ff2d24d6bfa00000(0000) knlGS:0000000000000000 [ 1136.028765] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 1136.034510] CR2: 00007fd207f90b80 CR3: 000000163ea22003 CR4: 0000000000f73ef0 [ 1136.041641] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 1136.048776] DR3: 0000000000000000 DR6: 00000000fffe07f0 DR7: 0000000000000400 [ 1136.055910] PKRU: 55555554 [ 1136.058623] Call Trace: [ 1136.061074] [ 1136.063179] ? show_trace_log_lvl+0x1b0/0x2f0 [ 1136.067540] ? show_trace_log_lvl+0x1b0/0x2f0 [ 1136.071898] ? move_linked_works+0x4a/0xa0 [ 1136.075998] ? __list_del_entry_valid_or_report.cold+0xf/0x6f [ 1136.081744] ? __die_body.cold+0x8/0x12 [ 1136.085584] ? die+0x2e/0x50 [ 1136.088469] ? do_trap+0xca/0x110 [ 1136.091789] ? do_error_trap+0x65/0x80 [ 1136.095543] ? __list_del_entry_valid_or_report.cold+0xf/0x6f [ 1136.101289] ? exc_invalid_op+0x50/0x70 [ 1136.105127] ? __list_del_entry_valid_or_report.cold+0xf/0x6f [ 1136.110874] ? asm_exc_invalid_op+0x1a/0x20 [ 1136.115059] ? __list_del_entry_valid_or_report.cold+0xf/0x6f [ 1136.120806] move_linked_works+0x4a/0xa0 [ 1136.124733] worker_thread+0x216/0x3a0 [ 1136.128485] ? __pfx_worker_thread+0x10/0x10 [ 1136.132758] kthread+0xfa/0x240 [ 1136.135904] ? __pfx_kthread+0x10/0x10 [ 1136.139657] ret_from_fork+0x31/0x50 [ 1136.143236] ? __pfx_kthread+0x10/0x10 [ 1136.146988] ret_from_fork_asm+0x1a/0x30 [ 1136.150915] Fixes: 19fce0470f05 ("nvme-fc: avoid calling _nvme_fc_abort_outstanding_ios from interrupt context") Cc: stable@vger.kernel.org Tested-by: Marco Patalano Reviewed-by: Justin Tee Signed-off-by: Ewan D. Milne Signed-off-by: Keith Busch Signed-off-by: Greg Kroah-Hartman Signed-off-by: Jaskaran Singh --- drivers/nvme/host/fc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nvme/host/fc.c b/drivers/nvme/host/fc.c index 31a9ae0eb2a7..3deca0d9a26b 100644 --- a/drivers/nvme/host/fc.c +++ b/drivers/nvme/host/fc.c @@ -3259,13 +3259,13 @@ nvme_fc_delete_ctrl(struct nvme_ctrl *nctrl) { struct nvme_fc_ctrl *ctrl = to_fc_ctrl(nctrl); - cancel_work_sync(&ctrl->ioerr_work); cancel_delayed_work_sync(&ctrl->connect_work); /* * kill the association on the link side. this will block * waiting for io to terminate */ nvme_fc_delete_association(ctrl); + cancel_work_sync(&ctrl->ioerr_work); } static void -- 2.43.7