From: Jakub Kicinski <kuba@kernel.org>
To: Siddharth Vadapalli <s-vadapalli@ti.com>
Cc: <andrew+netdev@lunn.ch>, <davem@davemloft.net>,
<edumazet@google.com>, <pabeni@redhat.com>, <danishanwar@ti.com>,
<rogerq@kernel.org>, <horms@kernel.org>, <mwalle@kernel.org>,
<nm@ti.com>, <v-singh1@ti.com>, <vadim.fedorenko@linux.dev>,
<matthias.schiffer@ew.tq-group.com>, <vigneshr@ti.com>,
<m-malladi@ti.com>, <jacob.e.keller@intel.com>,
<stable@vger.kernel.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <srk@ti.com>
Subject: Re: [PATCH net 2/3] net: ethernet: ti: icssg_common: set irq_disabled after disabling TX IRQ
Date: Tue, 24 Feb 2026 15:49:53 -0800 [thread overview]
Message-ID: <20260224154953.63b558c1@kernel.org> (raw)
In-Reply-To: <57e05b57556e94ed666acd8b4c542efc28e7408b.camel@ti.com>
On Tue, 24 Feb 2026 17:54:18 +0530 Siddharth Vadapalli wrote:
> CPU0
> CPU1
> ----------------
> --------------
> 1. TX HARD IRQ Handler entered NAPI TX
> Handler is running
> 2. irq_disabled is
> set Sees irq_disabled being set
> 3. Starts executing disable_irq_nosync() Invokes
> enable_irq() for TX IRQ before its really disabled
Could you resend your last email fixing the line wrap issue? It's very
hard to read as it arrived on the list.
From what I gather you're concerned about the case when hard IRQ and
NAPI run in parallel. But I don't see how that could ever happen for
Tx (there are some complexities like netpoll and busy poll but those
will return false from napi_complete_done()).
next prev parent reply other threads:[~2026-02-24 23:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-20 4:11 [PATCH net 0/3] Fix Unbalanced IRQ Enable for CPSW and ICSSG Siddharth Vadapalli
2026-02-20 4:11 ` [PATCH net 1/3] net: ethernet: ti: am65-cpsw-nuss: set irq_disabled after disabling RX IRQ Siddharth Vadapalli
2026-02-24 2:48 ` Jakub Kicinski
2026-02-24 5:10 ` Siddharth Vadapalli
2026-02-24 23:54 ` Jakub Kicinski
2026-02-25 11:12 ` Siddharth Vadapalli
2026-02-20 4:11 ` [PATCH net 2/3] net: ethernet: ti: icssg_common: set irq_disabled after disabling TX IRQ Siddharth Vadapalli
2026-02-24 2:48 ` Jakub Kicinski
2026-02-24 12:24 ` Siddharth Vadapalli
2026-02-24 23:49 ` Jakub Kicinski [this message]
2026-02-25 11:31 ` Siddharth Vadapalli
2026-02-26 0:09 ` Jakub Kicinski
2026-02-26 11:34 ` Siddharth Vadapalli
2026-02-20 4:11 ` [PATCH net 3/3] net: ethernet: ti: icssg_common: set irq_disabled after disabling RX IRQ Siddharth Vadapalli
2026-02-20 10:00 ` [PATCH net 0/3] Fix Unbalanced IRQ Enable for CPSW and ICSSG Malladi, Meghana
2026-02-23 17:39 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260224154953.63b558c1@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=danishanwar@ti.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m-malladi@ti.com \
--cc=matthias.schiffer@ew.tq-group.com \
--cc=mwalle@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nm@ti.com \
--cc=pabeni@redhat.com \
--cc=rogerq@kernel.org \
--cc=s-vadapalli@ti.com \
--cc=srk@ti.com \
--cc=stable@vger.kernel.org \
--cc=v-singh1@ti.com \
--cc=vadim.fedorenko@linux.dev \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox