From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA13A4369A; Wed, 25 Feb 2026 01:29:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771982961; cv=none; b=cANAkjYQKd2Xjd5xy+GAnMlLtr3E3Po4ZQB4eOH9igXR5v/ssPkeMxRvIfoKbFL+t9Ob5L7lrPtldW5knVb8beC7ID9DcG4w2QCSOgRHMXu2SR6CDcMKT4idEB9IgzExTRg6rSeJrFy/B5vi9Ha+r0jOatSjRFveBc0s7TKBiPs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771982961; c=relaxed/simple; bh=wuxB79if/loLRO72HdiyYy+f4y7vjbOlXUF6DyPcJHI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MUhhPJXNrKNRlu/JFBsIoj5ZB/Ks3LxdcKAyqgJqFMjC9plzKlGgvkKRjl/yMtqYmxghlXh3IDN3uDtHeRvEhHt20sRedLmO2+6D6IhYvEzxnaGqugwSJet68igNX8CZfYj9y/DYw8Ne713KhtKAXHlCPfNCBnEkp+BSPo74XbE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=UmJRI9rj; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="UmJRI9rj" Received: by smtp.kernel.org (Postfix) with ESMTPSA id ADB38C116D0; Wed, 25 Feb 2026 01:29:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1771982960; bh=wuxB79if/loLRO72HdiyYy+f4y7vjbOlXUF6DyPcJHI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UmJRI9rjr+rl2xuN0BgCcj+aWwY2WLk4GsNi6vyssSdfRUI/+4EYMdo4TBjvt9Ais K39wWnlxo1O2SpUUvy7wvsZi0MFZfvuyMzx1GChnt0VyLLiv8T+7FklKxvq9ZXwMfY CKaOi3hKirQ1JwJCOI1SE969x1ntAGPK9G56kpfg= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Aleksandr Loktionov , Larysa Zaremba , Alexei Starovoitov , Sasha Levin Subject: [PATCH 6.19 137/781] selftests/xsk: fix number of Tx frags in invalid packet Date: Tue, 24 Feb 2026 17:14:06 -0800 Message-ID: <20260225012403.030960421@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260225012359.695468795@linuxfoundation.org> References: <20260225012359.695468795@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Larysa Zaremba [ Upstream commit 88af9fefed412e4bea9a1a771cbe6fe347fa3507 ] The issue occurs in TOO_MANY_FRAGS test case when xdp_zc_max_segs is set to an odd number. TOO_MANY_FRAGS test case contains an invalid packet consisting of (xdp_zc_max_segs) frags. Every frag, even the last one has XDP_PKT_CONTD flag set. This packet is expected to be dropped. After that, there is a valid linear packet, which is expected to be received back. Once (xdp_zc_max_segs) is an odd number, the last packet cannot be received, if packet forwarding between Rx and Tx interfaces relies on the ethernet header, e.g. checks for ETH_P_LOOPBACK. Packet is malformed, if all traffic is looped. Turns out, sending function processes multiple invalid frags as if they were in 2-frag packets. So once the invalid mbuf packet contains an odd number of those, the valid packet after gets paired with the previous invalid descriptor, and hence does not get an ethernet header generated, so it is either dropped or malformed. Make invalid packets in verbatim mode always have only a single frag. For such packets, number of frags is otherwise meaningless, as descriptor flags are pre-configured in verbatim mode and packet data is not generated for invalid descriptors. Fixes: 697604492b64 ("selftests/xsk: add invalid descriptor test for multi-buffer") Reviewed-by: Aleksandr Loktionov Signed-off-by: Larysa Zaremba Link: https://lore.kernel.org/r/20260203155103.2305816-3-larysa.zaremba@intel.com Signed-off-by: Alexei Starovoitov Signed-off-by: Sasha Levin --- tools/testing/selftests/bpf/prog_tests/test_xsk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/bpf/prog_tests/test_xsk.c b/tools/testing/selftests/bpf/prog_tests/test_xsk.c index 69a5a9a5189b0..bab4a31621c75 100644 --- a/tools/testing/selftests/bpf/prog_tests/test_xsk.c +++ b/tools/testing/selftests/bpf/prog_tests/test_xsk.c @@ -433,7 +433,7 @@ static u32 pkt_nb_frags(u32 frame_size, struct pkt_stream *pkt_stream, struct pk } /* Search for the end of the packet in verbatim mode */ - if (!pkt_continues(pkt->options)) + if (!pkt_continues(pkt->options) || !pkt->valid) return nb_frags; next_frag = pkt_stream->current_pkt_nb; -- 2.51.0