From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 44EE71E2834; Wed, 25 Feb 2026 01:32:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771983175; cv=none; b=qHFEDL0luDPaFnWqn3TpCQizKYtZw+AyoZPFCXztToEqonsqtPyMSSBJ44kWl525oIBQRUXrcyExBc0XvjGmP103JdkDAYuBFEU5GGsqzqJpiJXSKYHNxeEeWry38ENUHt3lfyU/dIIKTiX8h3C+sNGLOuRSr3VSHgr3iDLGCLU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771983175; c=relaxed/simple; bh=yy3/pnt8Nd6nl/naPdnDOBQLvqZ58i3hiHDZhDCZRpM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=kIlD98+zLh58fjwNaJQhOmM3cRpK8N1ZlhKjeAm97EWgVI1E4Cb7otPGafNL3ua8TXTgCUGLEujmY1mJjI2IaHDOTeYcuH8ww2r+0W3k6TMjQLqn3HsoMFrxEMc2RjW/rbf8sB7JNNnuacSFLubuET0hIHo4HMqhhiipiISfYtg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=B7+P7hsR; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="B7+P7hsR" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 007E6C116D0; Wed, 25 Feb 2026 01:32:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1771983175; bh=yy3/pnt8Nd6nl/naPdnDOBQLvqZ58i3hiHDZhDCZRpM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=B7+P7hsRnW9KEjF4K1y9ZBhTkhrq7c5SDSU8Hx53O70IgghqPl1NyziXAgaNmhydy hRym+tEAMs6FA5K0cpVK3fmPJnpXGTB/vaN3/Q5596ysOiYXEIqrZMkqK5GM6RzTz+ 0ke2jHZtDhgqXjrOKE1ew7xtOAY5FstWM7+JbxHc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, =?UTF-8?q?H=C3=A5kon=20Bugge?= , Bjorn Helgaas , Zhu Yanjun , Sasha Levin Subject: [PATCH 6.19 327/781] PCI: Do not attempt to set ExtTag for VFs Date: Tue, 24 Feb 2026 17:17:16 -0800 Message-ID: <20260225012407.725153674@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260225012359.695468795@linuxfoundation.org> References: <20260225012359.695468795@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 6.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Håkon Bugge [ Upstream commit 73711730a1128d91ebca1a6994ceeb18f36cb0cd ] The bit for enabling extended tags is Reserved and Preserved (RsvdP) for VFs, according to PCIe r7.0 section 7.5.3.4 table 7.21. Hence, bail out early from pci_configure_extended_tags() if the device is a VF. Otherwise, we may see incorrect log messages such as: kernel: pci 0000:af:00.2: enabling Extended Tags (af:00.2 is a VF) Fixes: 60db3a4d8cc9 ("PCI: Enable PCIe Extended Tags if supported") Signed-off-by: Håkon Bugge Signed-off-by: Bjorn Helgaas Reviewed-by: Zhu Yanjun Link: https://patch.msgid.link/20251112095442.1913258-1-haakon.bugge@oracle.com Signed-off-by: Sasha Levin --- drivers/pci/probe.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c index 41183aed8f5d9..86665658d7047 100644 --- a/drivers/pci/probe.c +++ b/drivers/pci/probe.c @@ -2270,7 +2270,8 @@ int pci_configure_extended_tags(struct pci_dev *dev, void *ign) u16 ctl; int ret; - if (!pci_is_pcie(dev)) + /* PCI_EXP_DEVCTL_EXT_TAG is RsvdP in VFs */ + if (!pci_is_pcie(dev) || dev->is_virtfn) return 0; ret = pcie_capability_read_dword(dev, PCI_EXP_DEVCAP, &cap); -- 2.51.0