From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EAF8218DB2A; Wed, 25 Feb 2026 01:34:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771983251; cv=none; b=k282JYzVtnvxgwbItw08VSwRtZMOjaFzAOrm/f49KkaLpQB0lWRAzRE7tfyjuI+ku3XCOOnBEWNYT7rgFDtsrf1bmHRJ90uwTe7qK1lQhFp3RvXftPFJsVCx3iwf0LfDbVWdilQhKwIKmkrsISoVpi73rfxRFLJQwH2Tb1SZzng= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771983251; c=relaxed/simple; bh=eCF/tB5tYvb+0kNqhNLs1A//y9Aqv8ykzUOgqsEg9/4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=C+n6VI7x9/75e6mcve8FsRZeM8ZxYYuIU7Wf9kQFVfZO7b1HxtlQWMqH8teMj/9etTiUPILuQqhtHrIGszCF+Jo1I7tHf8RlA3wuhFCumSM/i/4LQGbFfhtK/TdseDv+/ozZe+8Kiso3YjjzUvT8HqWbvf/LdTruifohidv8IW8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=bx1owhIv; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="bx1owhIv" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9FBD8C116D0; Wed, 25 Feb 2026 01:34:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1771983250; bh=eCF/tB5tYvb+0kNqhNLs1A//y9Aqv8ykzUOgqsEg9/4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bx1owhIvwUcRfaWtC5Ek/VhUgtRlbwLAzCykDtRhZ750S2cwbWBmWaAMEMbUOuhOU VpPsnVqjKN9pVmimdcvR17PHYN294DH/DbfjZVa9fSSgA8hlnp+odXIk5IWj0XuQbe ubdzkyG92PAOjHhVSoVT2t4jXZnTBaa7mSfPMgqo= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Petr Mladek , Daniel Gomez , Petr Pavlu , Aaron Tomlin , Alexei Starovoitov , Daniel Borkman , John Fastabend , Kees Cook , Luis Chamberalin , Marc Rutland , "Masami Hiramatsu (Google)" , Sami Tolvanen , "Steven Rostedt (Google)" , Andrew Morton , Sasha Levin Subject: [PATCH 6.19 350/781] module: add helper function for reading module_buildid() Date: Tue, 24 Feb 2026 17:17:39 -0800 Message-ID: <20260225012408.275993227@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260225012359.695468795@linuxfoundation.org> References: <20260225012359.695468795@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Petr Mladek [ Upstream commit acfdbb4ab2910ff6f03becb569c23ac7b2223913 ] Add a helper function for reading the optional "build_id" member of struct module. It is going to be used also in ftrace_mod_address_lookup(). Use "#ifdef" instead of "#if IS_ENABLED()" to match the declaration of the optional field in struct module. Link: https://lkml.kernel.org/r/20251128135920.217303-4-pmladek@suse.com Signed-off-by: Petr Mladek Reviewed-by: Daniel Gomez Reviewed-by: Petr Pavlu Cc: Aaron Tomlin Cc: Alexei Starovoitov Cc: Daniel Borkman Cc: John Fastabend Cc: Kees Cook Cc: Luis Chamberalin Cc: Marc Rutland Cc: "Masami Hiramatsu (Google)" Cc: Sami Tolvanen Cc: Steven Rostedt (Google) Signed-off-by: Andrew Morton Stable-dep-of: e8a1e7eaa19d ("kallsyms/ftrace: set module buildid in ftrace_mod_address_lookup()") Signed-off-by: Sasha Levin --- include/linux/module.h | 9 +++++++++ kernel/module/kallsyms.c | 9 ++------- 2 files changed, 11 insertions(+), 7 deletions(-) diff --git a/include/linux/module.h b/include/linux/module.h index d80c3ea574726..ac254525014cd 100644 --- a/include/linux/module.h +++ b/include/linux/module.h @@ -748,6 +748,15 @@ static inline void __module_get(struct module *module) __mod ? __mod->name : "kernel"; \ }) +static inline const unsigned char *module_buildid(struct module *mod) +{ +#ifdef CONFIG_STACKTRACE_BUILD_ID + return mod->build_id; +#else + return NULL; +#endif +} + /* Dereference module function descriptor */ void *dereference_module_function_descriptor(struct module *mod, void *ptr); diff --git a/kernel/module/kallsyms.c b/kernel/module/kallsyms.c index 00a60796327c0..0fc11e45df9b9 100644 --- a/kernel/module/kallsyms.c +++ b/kernel/module/kallsyms.c @@ -334,13 +334,8 @@ int module_address_lookup(unsigned long addr, if (mod) { if (modname) *modname = mod->name; - if (modbuildid) { -#if IS_ENABLED(CONFIG_STACKTRACE_BUILD_ID) - *modbuildid = mod->build_id; -#else - *modbuildid = NULL; -#endif - } + if (modbuildid) + *modbuildid = module_buildid(mod); sym = find_kallsyms_symbol(mod, addr, size, offset); -- 2.51.0