From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE43118B0A; Wed, 25 Feb 2026 01:35:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771983327; cv=none; b=bj0QYErrTBt/LWFRFEi8LLRtYp70NBJ23/FVIG3BOzGSxKhiUm0ndNRjfCWQ0aJy4VTmA2E/wjstWhKTGPma025M2vdar4CORC09mPz34oZkN7G/Qo0OG8BQKoLwe5CU/CjV7pK7MsoRioDGb0z+7tI+7b7RLOKh0To5tBUgNoI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771983327; c=relaxed/simple; bh=15cOaFP7CrNSmeiPgRWqa00kJarpb8vRZwBr1KrTpGU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LIy9exgM9zEkBPJSyNv1bGvMi+4xNqRGVcc7Lx6S9OxjxUCyqbH7hqe/H8llvF2WH5Wmf7ubYSEvGom7wsz9+8M3ueY3sGa9xRnOhl5ovLNy+Qiiie2zQ2D36C+XJj3TYjDy0e9Jxxf1BodXmNz42sn69ztBsIkA4YEnvjiI93Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=LAxoVW+I; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="LAxoVW+I" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6FE59C116D0; Wed, 25 Feb 2026 01:35:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1771983327; bh=15cOaFP7CrNSmeiPgRWqa00kJarpb8vRZwBr1KrTpGU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LAxoVW+IQMMtfoCwxviMfuJFn/8ED88HfQJHcKJLAdpYAQIHoIptfbgQGn6noUM/7 5XNkyW8YLwDuzBXF8d3yyIkZvjWs9ocgIjfj5etlsM+K75OM571yZAHWe+qqzisPzb z6Ga9FF+hxJhg6KLUSVgHNDBEvRF62+uORJGfcRk= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Haotian Zhang , Matt Ranostay , Sebastian Reichel , Sasha Levin Subject: [PATCH 6.19 459/781] power: supply: bq27xxx: fix wrong errno when bus ops are unsupported Date: Tue, 24 Feb 2026 17:19:28 -0800 Message-ID: <20260225012410.977814321@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260225012359.695468795@linuxfoundation.org> References: <20260225012359.695468795@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Haotian Zhang [ Upstream commit 688364a11647dc09ba1e4429313e0008066ec790 ] bq27xxx_write(), bq27xxx_read_block(), and bq27xxx_write_block() return -EPERM when the bus callback pointer is NULL. A NULL callback indicates the operation is not supported by the bus/driver, not that permission is denied. Return -EOPNOTSUPP instead of -EPERM when di->bus.write/ read_bulk/write_bulk is NULL. Fixes: 14073f6614f6 ("power: supply: bq27xxx: Add bulk transfer bus methods") Signed-off-by: Haotian Zhang Reviewed-by: Matt Ranostay Link: https://patch.msgid.link/20251204083436.1367-1-vulab@iscas.ac.cn Signed-off-by: Sebastian Reichel Signed-off-by: Sasha Levin --- drivers/power/supply/bq27xxx_battery.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/power/supply/bq27xxx_battery.c b/drivers/power/supply/bq27xxx_battery.c index 19445e39651c7..45f0e39b8c2dd 100644 --- a/drivers/power/supply/bq27xxx_battery.c +++ b/drivers/power/supply/bq27xxx_battery.c @@ -1172,7 +1172,7 @@ static inline int bq27xxx_write(struct bq27xxx_device_info *di, int reg_index, return -EINVAL; if (!di->bus.write) - return -EPERM; + return -EOPNOTSUPP; ret = di->bus.write(di, di->regs[reg_index], value, single); if (ret < 0) @@ -1191,7 +1191,7 @@ static inline int bq27xxx_read_block(struct bq27xxx_device_info *di, int reg_ind return -EINVAL; if (!di->bus.read_bulk) - return -EPERM; + return -EOPNOTSUPP; ret = di->bus.read_bulk(di, di->regs[reg_index], data, len); if (ret < 0) @@ -1210,7 +1210,7 @@ static inline int bq27xxx_write_block(struct bq27xxx_device_info *di, int reg_in return -EINVAL; if (!di->bus.write_bulk) - return -EPERM; + return -EOPNOTSUPP; ret = di->bus.write_bulk(di, di->regs[reg_index], data, len); if (ret < 0) -- 2.51.0