From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E2F3E1D5141; Wed, 25 Feb 2026 01:37:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771983443; cv=none; b=bqpYXeD6AgwZ5SfUCb7SSSyazTfwre89XzVyIScoGVp+sSnroSkUyXSR1951I0zVSEv2boh9f+DJAfoXdMl0uPba+KspKX7vSO2auVwD7LNcNPAs1i8rQhUBh3XDCrZ1xswZk/XE/hHGNbfQzht7mlJ+Aw+faQHc237+UfrBZIM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771983443; c=relaxed/simple; bh=0405cv4o7z+OTATBwRo430Oz+exppZjXViXTRRBe3d4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eOzcTiJcO3u5zG9T32rZCamgauDTVZY5PZqunkLQuFxXDY6JDLfPGhVr3gDs+EfOr8u+L8Hky9FR5PW421I8g7hAHJ/S6fd9z+lGIbzpBl6LK305lLUxGtBnNHSyNzQNyIEix4FKAnOaUuiC3vXixBCGTT2xSQdt6lSxZQWyxEQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=f+xyCBCj; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="f+xyCBCj" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7779AC116D0; Wed, 25 Feb 2026 01:37:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1771983442; bh=0405cv4o7z+OTATBwRo430Oz+exppZjXViXTRRBe3d4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=f+xyCBCjHL98TFJNtDJGt39HnZ8/plZfeze6hjdC51ZR9bCsD+rMguBI0E4uTaCgA ODuaOTyxT3h78nWCDGI81aUR7oDwJDH96PzWVK45aoQGtgzl03+Ue9ygPanu89i0/2 kjPjqnHXL0Pu92s8Y1ufVgcWYIZqE6q62fHgb+4U= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, AngeloGioacchino Del Regno , Nicolas Frattaroli , Georgi Djakov , Sasha Levin Subject: [PATCH 6.19 559/781] interconnect: mediatek: Dont hijack parent device Date: Tue, 24 Feb 2026 17:21:08 -0800 Message-ID: <20260225012413.513635073@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260225012359.695468795@linuxfoundation.org> References: <20260225012359.695468795@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Nicolas Frattaroli [ Upstream commit 510f8214440c553e81774c5822437ccf154e9e38 ] If the intention is that users of the interconnect declare their relationship to the child icc_emi node of the dvfsrc controller, then this code never worked. That's because it uses the parent dvfsrc device as the device it passes to the interconnect core framework, which means all the OF parsing is broken. Use the actual device instead, and pass the dvfsrc parent into the dvfsrc calls. Fixes: b45293799f75 ("interconnect: mediatek: Add MediaTek MT8183/8195 EMI Interconnect driver") Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Nicolas Frattaroli Link: https://lore.kernel.org/r/20251124-mt8196-dvfsrc-v2-12-d9c1334db9f3@collabora.com Signed-off-by: Georgi Djakov Signed-off-by: Sasha Levin --- drivers/interconnect/mediatek/icc-emi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/interconnect/mediatek/icc-emi.c b/drivers/interconnect/mediatek/icc-emi.c index 7da740b5fa8d6..182aa2b0623af 100644 --- a/drivers/interconnect/mediatek/icc-emi.c +++ b/drivers/interconnect/mediatek/icc-emi.c @@ -40,7 +40,7 @@ static int mtk_emi_icc_set(struct icc_node *src, struct icc_node *dst) if (unlikely(!src->provider)) return -EINVAL; - dev = src->provider->dev; + dev = src->provider->dev->parent; switch (node->ep) { case 0: @@ -97,7 +97,7 @@ int mtk_emi_icc_probe(struct platform_device *pdev) if (!data) return -ENOMEM; - provider->dev = pdev->dev.parent; + provider->dev = dev; provider->set = mtk_emi_icc_set; provider->aggregate = mtk_emi_icc_aggregate; provider->xlate = of_icc_xlate_onecell; -- 2.51.0