From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2092726158C; Wed, 25 Feb 2026 01:37:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771983455; cv=none; b=HxDMv011VbB4r2pTKFwBVwyWBRd+IqaMbyd8Y2sZ+TB3dqeh+XsP3OYDLJSA6/0qZmB8Qj/Wu3Rs/W1TLbpLGUoq+5StVRBkpFd5bKSf3oIyxET5bvoLLDPJedMw6l7hbHVDwtS9Xqka3L6gjf3OVK8uVmC1AIXzAu4qhP4V93U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771983455; c=relaxed/simple; bh=tjPYL7bcyQJMypk2tXGhuzdsbENTgO7tCPGzwsBy8zA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=p85Hz3dNmn+VA5efjLtEaLzoCsjlMYL5hYJv7vXX0TrAIBKM3hkneW8SPbv+l1nRgly6pE862eb3Rf/uXBLiMLvHIoek9Tuf3zmHDZmIxMAepJiUDk5b7d6mkOasqMZglKUKUgn0aFlulF9g2RF2dbJTatdhvrZDkSr3bTA5AkI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=ddnVvjWH; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="ddnVvjWH" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CD56CC19423; Wed, 25 Feb 2026 01:37:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1771983455; bh=tjPYL7bcyQJMypk2tXGhuzdsbENTgO7tCPGzwsBy8zA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ddnVvjWH1emMJ2DDopywOnAxYc9H/ZS8PBjlzvh7N7syJIcoXBNc/JcOt/1J7I2P5 ECEwdLWAw/qOck9aBVLHDVsIu7ZH2sBtqIp2L+37tBZ1kSJQUSBWe7G639pBorLkQm QfrgTb7ufOB4BvTkhKqQHITDW2q9osidEkdMyb24= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Rui Miguel Silva , Chaitanya Mishra , Sasha Levin Subject: [PATCH 6.19 569/781] staging: greybus: lights: avoid NULL deref Date: Tue, 24 Feb 2026 17:21:18 -0800 Message-ID: <20260225012413.761359828@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260225012359.695468795@linuxfoundation.org> References: <20260225012359.695468795@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Chaitanya Mishra [ Upstream commit efcffd9a6ad8d190651498d5eda53bfc7cf683a7 ] gb_lights_light_config() stores channel_count before allocating the channels array. If kcalloc() fails, gb_lights_release() iterates the non-zero count and dereferences light->channels, which is NULL. Allocate channels first and only then publish channels_count so the cleanup path can't walk a NULL pointer. Fixes: 2870b52bae4c ("greybus: lights: add lights implementation") Link: https://lore.kernel.org/all/20260108103700.15384-1-chaitanyamishra.ai@gmail.com/ Reviewed-by: Rui Miguel Silva Signed-off-by: Chaitanya Mishra Link: https://patch.msgid.link/20260108151254.81553-1-chaitanyamishra.ai@gmail.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/staging/greybus/light.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/staging/greybus/light.c b/drivers/staging/greybus/light.c index e509fdc715dbb..38c233a706c48 100644 --- a/drivers/staging/greybus/light.c +++ b/drivers/staging/greybus/light.c @@ -1008,14 +1008,18 @@ static int gb_lights_light_config(struct gb_lights *glights, u8 id) if (!strlen(conf.name)) return -EINVAL; - light->channels_count = conf.channel_count; light->name = kstrndup(conf.name, NAMES_MAX, GFP_KERNEL); if (!light->name) return -ENOMEM; - light->channels = kcalloc(light->channels_count, + light->channels = kcalloc(conf.channel_count, sizeof(struct gb_channel), GFP_KERNEL); if (!light->channels) return -ENOMEM; + /* + * Publish channels_count only after channels allocation so cleanup + * doesn't walk a NULL channels pointer on allocation failure. + */ + light->channels_count = conf.channel_count; /* First we collect all the configurations for all channels */ for (i = 0; i < light->channels_count; i++) { -- 2.51.0